Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial consistency question: Use "submenu" or "popup menu" in the menubar pattern and examples? #268

Closed
mcking65 opened this issue Feb 1, 2017 · 2 comments
Closed

Editorial consistency question: Use "submenu" or "popup menu" in the menubar pattern and examples? #268

mcking65 opened this issue Feb 1, 2017 · 2 comments
Assignees
@mcking65
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern question Issue asking a question
Milestone
Jan 2017 Clean Up

Comments

@mcking65
Copy link
Contributor

mcking65 commented Feb 1, 2017

In the
menu and menubar pattern
we use the term "submenu", but in the
navigation menubar
and
editor menubar
example pages, the term "popup" is used for the same element.

This inconsistency makes the text less clear.

Which term is more appropriate for these pages?

Or, is this not an issue?
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. question Issue asking a question labels Feb 1, 2017
@mcking65 mcking65 added this to the Jan 2017 Clean Up milestone Feb 1, 2017
@mcking65 mcking65 self-assigned this Feb 1, 2017
@mcking65
Copy link
Contributor Author

Discussed in Feb 6, 2017 meeting.

Consensus on using term "submenu" consistently.

@mcking65 will implement decision in menubar examples.

mcking65 added a commit that referenced this issue Jun 21, 2017
@mcking65
Editor Menubar Example: Improve Editorial Consistency and Fix Broken …
ff0b869 
…Links

For issue #144, made the following changes to the editor menubar example in examples/menubar/menubar-2/menubar-2.html.

1. Clarified and simplified introduction.
2. Moved Notes from example section in to a separate accessibility features section to be consistent with the example template.
3. Removed use of term "popup" and used "submenu" as agreed in issue #268.
4. Editorial revisions to keyboard tables.
5. Editorial revisions to role, state, and property tables.
6. Fix broken links to source files.
mcking65 added a commit that referenced this issue Jun 21, 2017
@mcking65
Navigation Menubar Example: Corrections and editorial revisions
8b40802 
For issue #267, made the following changes to examples/menubar/menubar-1/menubar-1.html.

1. Simplified and clarified introduction.
2. Revised notes for each example; removed incorrect information about use of named entities for icons.
3. Moved information about using CSS content property to accessibility features section.
4. Removed all uses of the term "popup" as agreed in issue #268 and revised to use the term "submenu" as appropriate.
5. Revised keyboard tables for consistency with editorial guidelines.
6. Add information about behavior of left and right arrrows when in sub submenus.
7. Revised role, state, and property tables for consistency with editorial guidelines.
8. Replaced link to closed review issue 145 with link to new review issue 410.
@mcking65
Copy link
Contributor Author

With completion of issues #144 and #267, work on this issue is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcking65 mcking65

Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern question Issue asking a question
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
Jan 2017 Clean Up
Development

No branches or pull requests
1 participant
@mcking65