Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu Button examples using role=none on <li> elements flagged by the Nu Validator #432

Closed
nschonni opened this issue Jul 20, 2017 · 7 comments
Closed

Menu Button examples using role=none on <li> elements flagged by the Nu Validator #432

nschonni opened this issue Jul 20, 2017 · 7 comments
Assignees
@jnurthen
Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Milestone
1.1 APG Release 1

Comments

@nschonni
Copy link
Contributor

https://github.com/w3c/aria-practices/blob/master/examples/menu-button/menu-button-links.html#L59-L84
Not sure if this is a Validator issue, or an issue with the examples
@jnurthen
Copy link
Member

Logged w3c/html-aria#78 against HTML in ARIA which the validator uses for its rules

@mcking65 mcking65 added the Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation label Jul 27, 2017
@mcking65 mcking65 added this to the 3Q17 Working Draft milestone Jul 27, 2017
@mcking65
Copy link
Contributor

I see that w3c/html-aria#78 is closed. Has the validator been updated?

@nschonni
Copy link
Contributor Author

The spec commit w3c/html-aria@f36423a landed at the end of September, but I don't see anything in the validator commits that seem to corrispond

@mcking65 mcking65 changed the title Menu Button examples using role=none on <li> elmements flagged by the Nu Validator Menu Button examples using role=none on <li> elements flagged by the Nu Validator Nov 27, 2017
@css-meeting-bot
Copy link
Member

The Working Group just discussed validation issue.

The full IRC log of that discussion <jemma> Topic: validation issue
<jamesn> Github:https://github.com//issues/432
<jemma> Github: https://github.com//issues/432
<jemma> james: I will talk to Michale Copper
<jemma> s/cooper/smith
<jamesn> s/Copper/Smith/
<jemma> role="none" is supported throughout browsers.
<mck> https://github.com//pull/421

@jnurthen
Copy link
Member

validator/validator#581 logged against validator

@mcking65
Copy link
Contributor

Closing with assumption that @sideshowbarker will update validator accordingly.

@sideshowbarker
Copy link

I’ve fixed this in the HTML checker and pushed the fix to https://validator.w3.org/nu/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnurthen jnurthen

Labels
Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
Command, Toggle, Menu, and Disclosure Button Patterns and Examples Development Project
Status: Complete
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
1.1 APG Release 1
Development

No branches or pull requests
5 participants
@sideshowbarker @nschonni @jnurthen @mcking65 @css-meeting-bot