Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note addressing validation errors resulting from aria-expanded on menuitem elements to Menu and Menubar patterns and examples #447

Closed
mcking65 opened this issue Aug 28, 2017 · 8 comments
Assignees
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.

Comments

@mcking65
Copy link
Contributor

Feedback in issue #410
from @sideshowbarker describes confusion caused by validation errors that result from applying aria-expanded to menuitem elements.

Per discussion with task force, add notes to the patterns and examples where use of aria-expanded is recommended to explain that the ARIA specification mistakenly omitted aria-expanded for menuitem and this will be resolved in ARIA 1.2. In the meantime, even though it triggers errors from validators, using aria-expanded is still recommended.

@mcking65 mcking65 added documentation editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. labels Aug 28, 2017
@mcking65 mcking65 added this to the 3Q17 Working Draft milestone Aug 28, 2017
@mcking65 mcking65 self-assigned this Oct 8, 2017
mcking65 added a commit that referenced this issue Oct 8, 2017
For issue #447, Added the following note below the roles, states, and properties table on the navigation menubar example page:

> Currently, using aria-expanded on elements with role menuitem triggers HTML validation errors because the ARIA specification does not yet support doing so.
> The ARIA working group plans to resolve this issue in the next version of the specification.
> Until a version of ARIA that resolves the issue becomes a W3C recommendation, it is safe to ignore these validation errors.
> Alternatively, since only a few browser and assistive technology combinations exploit this feature of the pattern, it can be omitted from implementations.

IN the two rows of the table about aria-expanded, added text to see note below.
mcking65 added a commit that referenced this issue Oct 8, 2017
For issue #447, Added the following note below the roles, states, and properties table on the Editor menubar example page:

> Currently, using aria-expanded on elements with role menuitem triggers HTML validation errors because the ARIA specification does not yet support doing so.
> The ARIA working group plans to resolve this issue in the next version of the specification.
> Until a version of ARIA that resolves the issue becomes a W3C recommendation, it is safe to ignore these validation errors.
> Alternatively, since only a few browser and assistive technology combinations exploit this feature of the pattern, it can be omitted from implementations.

IN the two rows of the table about aria-expanded, added text to see note below.

Also added to 2 rows on the navigation menubar table that I overlooked in previous commit.
mcking65 added a commit that referenced this issue Oct 10, 2017
…alidation errors

To make it consistent with the menubar example pages, added aria-expanded for parent menu items to the
roles, states, and properties section of the menu and menubar design pattern.

For issue #447, added the same note used on the example pages:

> Currently, using aria-expanded on elements with role menuitem triggers HTML validation errors because the ARIA specification does not yet support doing so.
> The ARIA working group plans to resolve this issue in the next version of the specification.
> Until a version of ARIA that resolves the issue becomes a W3C recommendation,
> it is safe to ignore these validation errors.
> Alternatively, since only a few browser and assistive technology combinations exploit this feature of the pattern,
> it can be omitted from implementations.
@mcking65
Copy link
Contributor Author

@sideshowbarker, @Decrepidos, @stevefaulkner, @tmorehouse,

Commits dc4e6ef, 310801c, and 1c2446b add the following note to the design pattern, navigation menubar example, and editor menubar example pages. The task force reviewed this language in today's meeting.

Currently, using aria-expanded on elements with role menuitem triggers HTML validation errors because the ARIA specification does not yet support doing so.
The ARIA working group plans to resolve this issue in the next version of the specification.
Until a version of ARIA that resolves the issue becomes a W3C recommendation,
it is safe to ignore these validation errors.
Alternatively, since only a few browser and assistive technology combinations exploit this feature of the pattern,
it can be omitted from implementations.

Closing this issue as resolved. Please feel free to re-open if you believe we have not adequately addressed the issue.

@sideshowbarker
Copy link

sideshowbarker commented Oct 10, 2017

I am not satisfied with this resolution.

It’s not OK to tell authors, “Ignore what the ARIA spec says and ignore what the validator says."

And as I’ve noted over in 310801c#commitcomment-24845322, we don’t need for the ARIA spec to be at Recommendation as far as the validator is concerned. We just need for the ARIA WG to provide a spec with an actual normative requirement for this that the validator can then conform to. It doesn’t need to be Rec, and it doesn’t even need to be Working Draft. It can just be an Editor’s Draft.

@mcking65 mcking65 reopened this Oct 11, 2017
@mcking65
Copy link
Contributor Author

@sideshowbarker commented:

I am not satisfied with this resolution.

It’s not OK to tell authors, “Ignore what the ARIA spec says and ignore what the validator says."

Isn't this different from asking people to ignore the spec when there is a clear plan for the spec to resolve the issue?

we don’t need for the ARIA spec to be at Recommendation as far as the validator is concerned. We just need for the ARIA WG to provide a spec with an actual normative requirement for this that the validator can then conform to. It doesn’t need to be Rec, and it doesn’t even need to be Working Draft. It can just be an Editor’s Draft.

While liberating, I am surprised and confused. Since ARIA is a rec track doc, and since features do get pulled from the editor's draft, does that mean that a page that validates today may not validate tomorrow because it uses a feature that validated today but will not tomorrow because it was pulled from the editor's draft and then from the validator?

In the case of aria-expanded on parent menuitems, I believe we have consensus. And, we have enough implementation in browsers and ssistive tech to prove value. So, the risk of a plan change here is extremely low.

@michael-n-cooper, @joanmarie, when will we be able to merge ARIA 1.2 changes into the editor's draft? Possibly before ARIA 1.1 is a recommendation and before we publish the APG?

@michael-n-cooper
Copy link
Member

In theory we could set up editors' draft for ARIA 1.2 before ARIA 1.1 is a Rec. However, one major gating factor is the repository split, which we want to do after 1.1 has stabilized and before we start work on 1.2. Also I believe Joanie has in mind a versioning via branches approach that I'm not fully clear on, so we need to get that set up. These things need "sitting down to" but I know Joanie is flat-out trying to get 1.1 past CR right now so wouldn't look at this right away.

I also worry about having a 1.2 editors' draft at URI being used for the 1.1 editors' draft while 1.1 is still under development. We could of course set up a different URI but I don't think we were expecting to.

All this to say, I'm not sure we can promise what you want before Rec, but we can explore doing it in a few weeks if it seems not too crazy for our schedules.

@mcking65
Copy link
Contributor Author

@sideshowbarker,

We now have an editor's draft of ARIA 1.2 where the menuitem role now states that it supports aria-expanded.

We are planning to publish the ARIA Authoring Practices 1.1 as a Note this week. We have 24 hours left before cutting the publication branch. We could remove these notes about ignoring the validator error. Or, we could revise them to state that it is safe to ignore them until the validator is updated, which will be done in the near future ... or something like that.

@sideshowbarker
Copy link

We now have an editor's draft of ARIA 1.2 where the menuitem role now states that it supports aria-expanded.

Excellent — I can get the validator updated today. Will post another comment here as soon as I’ve committed and pushed the change

mcking65 added a commit that referenced this issue Dec 11, 2017
…idating

For issue #447, reversed changes made in commits 310801c, 1c2446b, and dc4e6ef.
There are no longer notes stating to ignore validation errors.
Based on comment by @sideshowbarker in issue #447, such errors will soon no longer be generated by the validator.
@mcking65
Copy link
Contributor Author

Fixed with commit 28bf229 so we can cut our publication branch this afternoon for publication on Thursday.

sideshowbarker added a commit to validator/validator that referenced this issue Jan 4, 2018
Per https://w3c.github.io/aria/#menuitem (ARIA 1.2) the `aria-expanded` state is
now allowed for `role=menuitem`.

This change also allows the `aria-posinset` and `aria-setsize` properties for
`role=menuitem` (which apparently have always been valid for it since ARIA 1.0,
but for some reason the checker was never yet coded to allow them...).

Relates to w3c/aria-practices#447
@sideshowbarker
Copy link

I’ve updated the HTML checker sources and pushed the update to https://validator.w3.org/nu/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Development

No branches or pull requests

3 participants