Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar Example: aria-selected should not be used. #540

Closed
mcking65 opened this issue Nov 26, 2017 · 2 comments
Closed

Toolbar Example: aria-selected should not be used. #540

mcking65 opened this issue Nov 26, 2017 · 2 comments
Assignees
@mcking65
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern good first issue Issue with Straightforward resolution; could be good learning experience for new contributors help wanted Task force is looking for an owner for the issue
Milestone
1.1 APG Release 1

Comments

@mcking65
Copy link
Contributor

In the toolbar example,
aria-selected is being applied to the elements in the toolbar.
This should not be done. The elements in the toolbar are focusable, but not selectable.

Remove aria-selected from the static HTML and the code that sets it from the javascript.
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Nov 26, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 1 milestone Nov 26, 2017
@mcking65 mcking65 changed the title Toolbar Example: aria-selected should not be used in the toolbar example Toolbar Example: aria-selected should not be used. Nov 26, 2017
@mcking65 mcking65 mentioned this issue Nov 26, 2017
Closed
6 tasks
@mcking65 mcking65 added good first issue Issue with Straightforward resolution; could be good learning experience for new contributors help wanted Task force is looking for an owner for the issue labels Nov 26, 2017
@mcking65 mcking65 self-assigned this Nov 27, 2017
@mcking65
Copy link
Contributor Author

@gerardkcohen has volunteered to submit a PR for this issue.

gerardkcohen added a commit to gerardkcohen/aria-practices that referenced this issue Nov 28, 2017
@gerardkcohen
w3c#540 remove use of aria-selected
a08eed0
@gerardkcohen gerardkcohen mentioned this issue Nov 28, 2017
Merged
mcking65 pushed a commit that referenced this issue Nov 29, 2017
@gerardkcohen @mcking65
Toolbar Example: Remove use of aria-selected (pull #546)
0fe1784 
Fixes issue #540.
@mcking65
Copy link
Contributor Author

mcking65 commented Nov 29, 2017 •
edited
Loading

Fixed with commit 0fe1784 with thanks to @gerardkcohen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcking65 mcking65

Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern good first issue Issue with Straightforward resolution; could be good learning experience for new contributors help wanted Task force is looking for an owner for the issue
Projects
Toolbar Pattern and Examples Development Project
Status: Complete
Milestone
1.1 APG Release 1
Development

No branches or pull requests
1 participant
@mcking65