Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guidelines for aria-level attribute #1003

Merged
merged 10 commits into from
Jul 19, 2019
Merged

Guidelines for aria-level attribute #1003

merged 10 commits into from
Jul 19, 2019

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Mar 18, 2019 •
edited by pr-preview bot
Loading

Rendered

Including this open issue on ARIA: w3c/aria#915

@zcorpan

Preview | Diff

@spectranaut spectranaut marked this pull request as ready for review June 26, 2019 11:44
@zcorpan zcorpan requested a review from mcking65 June 26, 2019 12:46
@a11ydoer a11ydoer self-assigned this Jul 2, 2019
@mcking65
Copy link
Contributor

@spectranaut, should we close this PR and replace it with one from the aria-level branch? I didn't compare this bocoup:aria-level branch to the w3c:aria-level branch, but I do see you committed to w3c:aria-level on June 26. So, I am guessing the one in the w3c repo is actually the latest work?

@spectranaut
Copy link
Contributor Author

I just compared and actually bocoup:aria-level has two more commits than w3c:aria-level (they are otherwise identical) -- I might have accidentally pushed to w3c:aria-level instead of bocoup:aria-level once. I'm going to delete the branch on w3c to avoid confusion in the future!

@mcking65
Copy link
Contributor

I prefer to work on a branch in the w3c repo. I will make a new one and land this work there.

@mcking65 mcking65 changed the base branch from master to issue259-aria-level-guidance July 19, 2019 21:16
@mcking65 mcking65 merged commit 4dcd209 into w3c:issue259-aria-level-guidance Jul 19, 2019
@mcking65
Copy link
Contributor

@spectranaut, could you please create a new PR with a compare branch of issue259-aria-level-guidance and base branch of master?

@spectranaut
Copy link
Contributor Author

sure thing :)

zcorpan pushed a commit that referenced this pull request Oct 31, 2019
@spectranaut @zcorpan
Initial draft of guidelines for aria-level attribute (pull #1003)
6bc16ee 
Initial draft of content for issue #259 to provide a guidance section on aria-level.
mcking65 pushed a commit that referenced this pull request Dec 2, 2019
@spectranaut @mcking65
Initial draft of guidelines for aria-level attribute (pull #1003)
5c575e0 
Initial draft of content for issue #259 to provide a guidance section on aria-level.
mcking65 pushed a commit that referenced this pull request Dec 15, 2020
@spectranaut @mcking65
Initial draft of guidelines for aria-level attribute (pull #1003)
0a8d0cd 
Initial draft of content for issue #259 to provide a guidance section on aria-level.
mcking65 pushed a commit that referenced this pull request Dec 15, 2020
@spectranaut @mcking65
Initial draft of guidelines for aria-level attribute (pull #1003)
6f67e9f 
Initial draft of content for issue #259 to provide a guidance section on aria-level.
zcorpan pushed a commit that referenced this pull request Nov 2, 2021
@spectranaut @zcorpan
Initial draft of guidelines for aria-level attribute (pull #1003)
369f676 
Initial draft of content for issue #259 to provide a guidance section on aria-level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 Awaiting requested review from mcking65

Assignees

@a11ydoer a11ydoer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spectranaut @mcking65 @a11ydoer @zcorpan