Toolbar Example: Add missing tooltips for issue 986 #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refer to popup labels
mcking65
changed the title
@spectranaut, this row had data-test-id="toolbar-button-aria-label". There are no longer aria-labels on these elements; they are now labeled by content. If this was a test that was getting run, it will now fail and should be removed. Deleting this row because we do not document or test implicit ARIA roles.
…ibing use of title attribute that is no longer included in the example.
mcking65
reviewed
Jul 6, 2019
There was a problem hiding this comment.
I pushed several changes, and it now looks good to me.
However, two of the changes I pushed modified or removed data-test-id values.
So, this needs further review by @spectranaut.
|
@jongund, @spectranaut can help resolve the remaining linting and testing issues with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #986 by adding "popup labels" (i.e. tooltips) that comply with WCAG 1.4.13 Content on Hover or Focus (AA) requirements.
Preview link
toolbar with WCAG 1.4.13 compliant popup labels