Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabbed carousel example for issue 955 #1120

Merged
merged 131 commits into from
Apr 30, 2020
Merged
Show file tree
Hide file tree
Changes from 117 commits
Commits
Show all changes
131 commits
Select commit Hold shift + click to select a range
9e304a1
update button example
jongund Mar 18, 2017
4e59e79
fixed references to external file
jongund Mar 27, 2017
76ff0ed
added auto rebase
jongund Mar 27, 2017
75a87f2
Merge branch 'master' of https://github.com/jongund/aria-practices
jongund May 24, 2018
0df77d2
removed gitcongif file
jongund Jun 27, 2018
a311e7d
Issue 43: Initial draft of carousel pattern (pull #829)
jongund Aug 21, 2018
4de2a50
Issue 458: First cut of Auto rotating image carousel example (pull #828)
jongund Aug 21, 2018
9f3105e
Merge remote-tracking branch 'w3c/master'
jongund Oct 1, 2018
c05d0f4
Merge remote-tracking branch 'w3c/master'
jongund Oct 5, 2018
7b2abc0
Merge remote-tracking branch 'w3c/master'
jongund Oct 8, 2018
b1d7d89
added feature
jongund Oct 8, 2018
1fad2b3
Merge remote-tracking branch 'w3c/master'
jongund Oct 10, 2018
f685318
update design pattern for carousel
jongund Nov 15, 2018
cecadd5
updated examples
jongund Nov 15, 2018
b5c3f12
update carousel 1 example
jongund Nov 15, 2018
ec7922b
updated carousel example
jongund Nov 16, 2018
0326934
updated carousel example
jongund Nov 16, 2018
5503d5c
updated carousel 2 example
jongund Nov 16, 2018
7f80c53
updated carousel 2 example
jongund Nov 16, 2018
49699de
Merge branch 'master' into w3c/carousel
jongund Nov 26, 2018
21e43f6
Merge pull request #945 from jongund/w3c/carousel
mcking65 Dec 4, 2018
7d008e8
Updated from master
jongund Dec 6, 2018
852757b
fixed liter problems and added two initial regression tests for each …
jongund Dec 6, 2018
f5f6098
Merge branch 'master' into carousel-v2
mcking65 Dec 7, 2018
8c73bf2
Merge branch 'master' into carousel-v2
mcking65 Dec 12, 2018
8090c27
Revise first paragraph; define carousel; remove implementation details.
mcking65 Dec 12, 2018
086b7ed
revise para2 of description
mcking65 Dec 12, 2018
7a493a1
Add placeholder folders and files
mcking65 Dec 12, 2018
cf9675a
Merge branch 'master' into carousel-v2
jongund Dec 17, 2018
2e0e351
Merge branch 'carousel-v2' of https://github.com/w3c/aria-practices i…
jongund Dec 17, 2018
08a6b64
initial commit of code for carousel with tabbed controls
jongund Dec 17, 2018
4efadcf
added issue that this example is tracked
jongund Dec 17, 2018
5c3ef0c
Delete carousel pattern section from aria-practices.html. It will be …
mcking65 Dec 18, 2018
671f754
Merge branch 'master' into issue955-add-tabbed-carousel-example
mcking65 Feb 4, 2019
7179f3e
Merge branch 'master' into issue955-add-tabbed-carousel-example
mcking65 Feb 27, 2019
aa5cccf
Merge branch 'master' into issue955-add-tabbed-carousel-example
jongund Jul 22, 2019
db0f296
updating carousel example using tablist based of carousel-1 example
jongund Jul 23, 2019
e94449a
initial code for tablist carousel
jongund Jul 30, 2019
7c4155b
updated documentation for carousel tabklist example
jongund Jul 30, 2019
f76640b
updated documentation for carousel tabklist example
jongund Jul 30, 2019
e673166
finished intial draft of carousel tab
jongund Aug 2, 2019
0ecbbef
updated where to place comments
jongund Aug 2, 2019
c0c8f4b
added aria-current
jongund Aug 2, 2019
4deb105
fixed typos
jongund Aug 27, 2019
6f2986c
unused code was removed
jongund Aug 27, 2019
16e10fe
fixed linting bug
jongund Aug 28, 2019
8acf974
added tests to example and added semi-transparent background to tabli…
jongund Aug 28, 2019
f4052ed
updated carosuel 2 example to comply with tab panel requirements and …
jongund Aug 28, 2019
8ccb133
removing tabindex from tab instead of setting tabindex=0
jongund Aug 28, 2019
bf25023
updated regression tests
jongund Aug 28, 2019
5debb8b
fixed linting errors
jongund Aug 28, 2019
1924047
Merge branch 'master' into issue955-add-tabbed-carousel-example
jongund Aug 28, 2019
14041d4
renamed regression test file
jongund Aug 28, 2019
b6aeffb
Merge branch 'master' into issue955-add-tabbed-carousel-example
mcking65 Sep 3, 2019
97c3e98
added missing regression tests
jongund Oct 15, 2019
479de43
moving to class based version of code and adding high contrast suppor…
jongund Oct 22, 2019
a6f9fdf
updaed code to use javascript class and improved high contrast focus …
jongund Oct 24, 2019
cf514e9
Change version in title and footer from 1.1 to 1.2
mcking65 Oct 24, 2019
a0a1ff0
updated documentation
jongund Oct 25, 2019
ba58a28
Merge branch 'issue955-add-tabbed-carousel-example' of github.com:w3c…
jongund Oct 25, 2019
fbd9912
added type=button to button elements
jongund Oct 27, 2019
e1e1804
Removed change to file.
svinkle Nov 9, 2019
bf121ca
removed tab stop on tabpanel
jongund Nov 20, 2019
3e8d79b
fixed test
jongund Nov 20, 2019
422a708
added ids to image links for regression testing
jongund Nov 20, 2019
e14746a
merged master
jongund Dec 4, 2019
b4086de
updated code to use prototype instead of class
jongund Dec 11, 2019
49eb621
changed let to var in for loops
jongund Dec 11, 2019
3d541d1
made changes identified by Carolyn MacLeod
jongund Jan 17, 2020
54234c6
fixed size bug
jongund Jan 18, 2020
90e1f75
edited linitnig bug
jongund Jan 19, 2020
bbf7411
added regression test for carousel-2a-tablist.html
jongund Jan 19, 2020
69ff39c
improved centering code for tablist
jongund Jan 20, 2020
1fd3cb9
improved centering code for tablist
jongund Jan 20, 2020
ea8b406
merged carousel-2-tablist.html and carousel-2a-tablist.html into one …
jongund Jan 21, 2020
85a6ed3
Merge branch 'master' into issue955-add-tabbed-carousel-example
mcking65 Jan 23, 2020
eb33386
Merge branch 'master' into issue955-add-tabbed-carousel-example
jongund Jan 24, 2020
8c92524
Remove link to PR
mcking65 Jan 26, 2020
b05904c
Editorial revisions to intro
mcking65 Jan 26, 2020
a2a7bba
Editorial revision to accessibility features section, including a not…
mcking65 Jan 26, 2020
82b0e0d
Editorial revision to high contrast support description under accessi…
mcking65 Jan 26, 2020
2cb6777
Editorial revisions to keyboard documentation
mcking65 Jan 26, 2020
73b566d
Editorial corrections to roles, states, and props documentation, add …
mcking65 Jan 27, 2020
42e10b1
Add links to carousel-2 from aria-practices main doc and carousel-1.
mcking65 Jan 27, 2020
1cbee94
Minor editorial revision to carousel-1 intro for consistency with car…
mcking65 Jan 27, 2020
8cbee0e
Minor editorial revision to carousel-1 accessibility features section…
mcking65 Jan 27, 2020
d71853c
Fix mistake in href values of links I just added to carousel-2
mcking65 Jan 27, 2020
15914a8
Minor fixes to the tests
Jan 27, 2020
492362e
Update description of slide rotation control features
mcking65 Jan 28, 2020
7739470
Make title more concise per request from Jemma
mcking65 Jan 28, 2020
c87ddeb
made code changes suggested by Sara Higley
jongund Jan 28, 2020
7c10170
fixed high contrast focus styling issue with links in slide
jongund Jan 28, 2020
1fcf9f1
fixed position of tabs in more accessible example
jongund Jan 28, 2020
20243c6
updated high contrast link focus styling
jongund Jan 29, 2020
6754d4d
added an feature to have the carousel stopped if word 'paused' is par…
jongund Jan 29, 2020
6ebf02a
Merge branch 'master' into issue955-add-tabbed-carousel-example
jongund Jan 29, 2020
417ada4
Merge branch 'master' into issue955-add-tabbed-carousel-example
mcking65 Feb 6, 2020
cd96d71
updated documentation on new pause button
jongund Feb 11, 2020
4707c6d
Merge branch 'master' into issue955-add-tabbed-carousel-example
jongund Feb 11, 2020
98eb03d
update pointer
jongund Feb 11, 2020
39734f6
updated to only have stopped pointer visible when carousel is playing…
jongund Feb 19, 2020
fd06273
fixed HTML linting bug
jongund Feb 19, 2020
a7c7f0e
improved descriptions of the carousel options
jongund Feb 19, 2020
c0bfbed
improved descriptions of the carousel options
jongund Feb 19, 2020
417de36
update hover and focus behavior
smhigley Mar 17, 2020
cd45946
update resetTimeout and fix url params
smhigley Mar 17, 2020
dea55d1
forgot to reset slide timing
smhigley Mar 24, 2020
cda64e7
restored package file from master
jongund Mar 31, 2020
d8a4ed1
Merge branch 'master' into issue955-add-tabbed-carousel-example
jongund Mar 31, 2020
25ee882
switch to checkboxes for carousel options
smhigley Apr 7, 2020
9b950fc
always start paused with prefers-reduced-motion
smhigley Apr 7, 2020
f8e8868
remove js styling, minor wording changes to options
smhigley Apr 15, 2020
7241a59
Merge pull request #1377 from w3c/tabbed-carousel-opt2
jongund Apr 16, 2020
bc63c5f
updated initialization of features and focus styling
jongund Apr 16, 2020
10c567b
update tests to conform to new pause behavior and aria-live attribute
jongund Apr 16, 2020
b1ecefb
updated file references
jongund Apr 17, 2020
9bff43a
added test for aria-label on each tab
jongund Apr 17, 2020
b1f62e3
made some samll changes including updating link to other carousel exa…
jongund Apr 20, 2020
d8695ea
added additional information about reload
jongund Apr 20, 2020
3f3247c
fixed linting bug
jongund Apr 20, 2020
a6f276c
updated based on teleconference today
jongund Apr 21, 2020
1637f1a
fixed some linting issues and rmeoved console.log
jongund Apr 21, 2020
2b128b9
Updated labeling of options
jongund Apr 21, 2020
387be99
update carousel to take options, handle prefers-reduced-motion
smhigley Apr 21, 2020
f8f4ae9
removed files from pull request that are not related to adding tablis…
jongund Apr 22, 2020
316e5b0
changed options.autoplay to options.paused in initialization of car…
jongund Apr 22, 2020
1a0174f
removed bug in initializing carousel more than once
jongund Apr 22, 2020
8aa49b3
Add note about reduced motion setting to "pause on load" checkbox
carmacleod Apr 28, 2020
7a53cd9
Remove periods from checkbox labels
carmacleod Apr 28, 2020
2a9d5bd
updated the hrefs
jongund Apr 28, 2020
67492f5
Merge branch 'master' into issue955-add-tabbed-carousel-example
mcking65 Apr 29, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions aria-practices.html
Original file line number Diff line number Diff line change
Expand Up @@ -508,10 +508,11 @@ <h3>Carousel (Slide Show or Image Rotator)</h3>
</ul>

<section class="notoc">
<h4>Example</h4>
<p>
<a href="examples/carousel/carousel-1.html">Auto-Rotating Image Carousel Example:</a> A basic image carousel that demonstrates the accessibility features necessary for carousels that rotate automatically on page load.
</p>
<h4>Examples</h4>
<ul>
<li><a href="examples/carousel/carousel-1.html">Auto-Rotating Image Carousel Example:</a> A basic image carousel that demonstrates the accessibility features necessary for carousels that rotate automatically on page load.</li>
<li><a href="examples/carousel/carousel-2-tablist.html">Example of Rotating Image Carousel Using a Tab List:</a> An image carousel that demonstrates using tabs to represent the controls that enable users to choose which slide to display.</li>
</ul>
</section>

<section class="notoc">
Expand Down
10 changes: 7 additions & 3 deletions examples/carousel/carousel-1.html
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,12 @@ <h1>Auto-Rotating Image Carousel Example</h1>
<a href="../../#carousel">carousel design pattern</a>
demonstrates features of the pattern that are essential to accessibility for carousels that automatically start rotating when the page loads.
For instance, rotation stops when users move focus to any control or link in the carousel or hover the mouse over carousel content.
The accessibility features section that follows the example describes these features in detail.
The accessibility features section that follows the example describes these aspects of the design in detail.
</p>
<p>Similar examples include:</p>
<ul>
<li><a href="carousel-2-tablist.html">Example of Rotating Image Carousel Using a Tab List:</a> An image carousel that demonstrates using tabs to represent the controls that enable users to choose which slide to display.</li>
</ul>

<section>
<h2>Example View Options</h2>
Expand Down Expand Up @@ -280,8 +284,8 @@ <h3>Controlling Automatic Slide Rotation</h3>
</ul>
<h3>Color Contrast of Text and Rotation Controls</h3>
<p>
In the view of this carousel where the controls and captions are displayed on top of the image, the background images can cause color contrast for the controls and text to become insufficient.
This view includes the following features to meet WCAG 2.1 color contrast requirements:
In the view of this carousel where the controls and captions are displayed on top of the image, background images could cause color contrast for the controls and text to become insufficient.
However, this view includes the following features to prevent this potential problem and ensure it meets WCAG 2.1 color contrast requirements:
</p>
<ul>
<li>
Expand Down
792 changes: 792 additions & 0 deletions examples/carousel/carousel-2-tablist.html

Large diffs are not rendered by default.

Loading