Combobox Pattern: Revise Escape behavior #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For issue #1066, revises description of escape behavior. Escape may optionally clear the text box, but only if the popup is hidden before escape is pressed. Previously, the pattern implied both could happen with a single press of escape, which is inconsistent with any known implementations.
smhigley
approved these changes
Aug 27, 2019
michael-n-cooper
pushed a commit
that referenced
this pull request
Aug 31, 2019
Combobox Pattern: Revise Escape behavior (pull #1129) For issue #1066, revises description of escape behavior. Escape may optionally clear the text box, but only if the popup is hidden before escape is pressed. Previously, the pattern implied both could happen with a single press of escape, which is inconsistent with any known implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #1066, revises description of escape behavior.
Escape may optionally clear the text box,
but only if the popup is hidden before escape is pressed.
Previously, the pattern implied both could happen with a single press of escape, which is inconsistent with any known implementations.
Preview | Diff