Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meter design pattern #1189

Merged
merged 9 commits into from
Nov 6, 2019
Merged

Add meter design pattern #1189

merged 9 commits into from
Nov 6, 2019

Conversation

smhigley
Copy link
Contributor

@smhigley smhigley commented Sep 30, 2019 •
edited by pr-preview bot
Loading

Initial draft of a meter pattern (the example implementation is tracked separately in #1105).

Resolves #979

Preview | Diff

carmacleod
carmacleod reviewed Oct 1, 2019
View reviewed changes
aria-practices.html Outdated Show resolved Hide resolved
carmacleod
carmacleod reviewed Oct 1, 2019
View reviewed changes
aria-practices.html Outdated Show resolved Hide resolved
carmacleod
carmacleod reviewed Oct 1, 2019
View reviewed changes
aria-practices.html Outdated Show resolved Hide resolved
@smhigley smhigley mentioned this pull request Oct 1, 2019
Merged
6 tasks
ZoeBijl
ZoeBijl reviewed Oct 1, 2019
View reviewed changes
aria-practices.html
@@ -294,7 +294,7 @@ <h4>Example</h4>

<section class="notoc">
<h4>Keyboard Interaction</h4>
<p>An alert (WAI-ARIA live region) does not require any keyboard interaction.</p>
<p>Not applicable.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

aria-practices.html Outdated
<section class="widget" id="meter">
<h3>Meter</h3>
<p>
A <a class="role-reference" href="#meter">meter</a> allows authors to define a value within a known range. The minimum and maximum limits of the range must be defined numerically, and the value should be a number within the range.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this definition, nice work!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

aria-practices.html Outdated
A <a class="role-reference" href="#meter">meter</a> allows authors to define a value within a known range. The minimum and maximum limits of the range must be defined numerically, and the value should be a number within the range.
</p>
<p>
Meter examples could include current battery percentage, or a car's fuel level. A <code>meter</code> could not be used to represent a value like the current world population, since there is no meaningful maximum limit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meter examples could include current battery percentage, or a car's fuel level

Propose to change this to:

Meter example include a device’s current batter percentage and a car’s fuel level.

A meter could not be used to

Propose we change to either:

A meter cannot be used to…

…or…

A meter should not be used to…

I think the first one is a little more strict and to the point. But the second one reads a little bit friendlier (and is more consistent with other text). Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like should, friendly sounds like a good approach :)

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Meter pattern and example.

The full IRC log of that discussion <carmacleod> TOPIC: Meter pattern and example
<carmacleod> github: Meter pattern and example
<carmacleod> github: https://github.com//pull/1189
<carmacleod> jemma: consider changing color as meter value gets closer to 100%?
<carmacleod> sarah: I can change the styling for this
<carmacleod> jemma: should we wait until ARIA 1.3 for this?
<carmacleod> mck: jemma is adding a review checklist to this
<carmacleod> siri: I don't like the animation - there's no pause/play button
<jamesn> q+
<carmacleod> james: Windows Task Manager allows pausing
<carmacleod> mck: should we add a pause button?
<carmacleod> group: yes
<carmacleod> sarah: I'll add a pause button when I am adding the color

mcking65
mcking65 requested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're really close here. There are just a couple places that should be refined a bit. I made suggestions.

aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
@smhigley
Copy link
Contributor Author

@mcking65 thanks for all your suggestions! I updated the PR to include them 👍

carmacleod
carmacleod approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we consider removing "or equal to" from valuemin and valuemax?
i.e. if a meter goes from 0 to 0 and has a value of 0, would AT say 0% or 100%? :)

@mcking65
Copy link
Contributor

mcking65 commented Nov 5, 2019 •
edited
Loading

@carmacleod wrote:

Looks good. Should we consider removing "or equal to" from valuemin and valuemax?
i.e. if a meter goes from 0 to 0 and has a value of 0, would AT say 0% or 100%? :)

Per discussion in today's meeting, changed this in commit 9525fea.

@mcking65 mcking65 merged commit 6ec616f into master Nov 6, 2019
michael-n-cooper pushed a commit that referenced this pull request Nov 6, 2019
Generated by TRAVIS-CI 6ec616f
5a6a441 
Add meter design pattern (pull #1189)

Resolve issue #979 by adding a section to the design patterns for elements with the meter role.
@zcorpan zcorpan deleted the 979-meter-pattern branch October 29, 2021 19:59
@zcorpan zcorpan mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZoeBijl ZoeBijl ZoeBijl left review comments

@mcking65 mcking65 mcking65 approved these changes

@carmacleod carmacleod carmacleod approved these changes

@a11ydoer a11ydoer Awaiting requested review from a11ydoer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draft meter pattern
5 participants
@smhigley @css-meeting-bot @mcking65 @carmacleod @ZoeBijl