Add guidance for aria-colindextext and aria-rowindextext for issue 1075 #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a11ydoer
approved these changes
Oct 29, 2019
carmacleod
reviewed
Nov 4, 2019
| @@ -5807,6 +5807,7 @@ <h2>Grid and Table Properties</h2> | |||
| <li>Whether any columns or rows are hidden, e.g., columns 1 through 3 and 5 through 8 are visible but column 4 is hidden.</li> | |||
| <li>Whether a cell spans multiple rows or columns.</li> | |||
| <li>Whether and how data is sorted.</li> | |||
| <li>How to communicate cell position, e.g., <q>row 2, column 2</q> or <q>row 2, column B</q> (like in most spread sheets). | |||
There was a problem hiding this comment.
No space in "spreadsheets".
There was a problem hiding this comment.
But how is it a real spreadsheet if it isn’t spread by a space? 🤔
carmacleod
reviewed
Nov 4, 2019
| @@ -5840,6 +5841,10 @@ <h2>Grid and Table Properties</h2> | |||
| </ul> | |||
| </td> | |||
| </tr> | |||
| <tr> | |||
| <th><code>aria-colindextext</code></th> | |||
| <td>Defines a human readable text alternative of aria-colindex .</td> | |||
There was a problem hiding this comment.
aria-colindex should be in <code>, and remove extra space before '.'
carmacleod
reviewed
Nov 4, 2019
| @@ -5849,6 +5854,10 @@ <h2>Grid and Table Properties</h2> | |||
| </ul> | |||
| </td> | |||
| </tr> | |||
| <tr> | |||
| <th><code>aria-rowindextext</code></th> | |||
| <td>Defines a human readable text alternative of aria-rowindex .</td> | |||
There was a problem hiding this comment.
aria-rowindex should be in <code>, and remove extra space before '.'
carmacleod
reviewed
Nov 4, 2019
| This is because some assistive technology functionality may rely on numerical position values. | ||
| </li> | ||
| <li> | ||
| Unlike aria-colindex, aria-colindextext cannot be specified on a row. |
There was a problem hiding this comment.
Add <code> for aria-colindex and aria-colindextext
carmacleod
requested changes
Nov 4, 2019
ZoeBijl
approved these changes
Nov 11, 2019
| @@ -5807,6 +5807,7 @@ <h2>Grid and Table Properties</h2> | |||
| <li>Whether any columns or rows are hidden, e.g., columns 1 through 3 and 5 through 8 are visible but column 4 is hidden.</li> | |||
| <li>Whether a cell spans multiple rows or columns.</li> | |||
| <li>Whether and how data is sorted.</li> | |||
| <li>How to communicate cell position, e.g., <q>row 2, column 2</q> or <q>row 2, column B</q> (like in most spread sheets). | |||
There was a problem hiding this comment.
But how is it a real spreadsheet if it isn’t spread by a space? 🤔
|
Approval hinges on the comments @carmacleod already made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1075 by adding new guidance to the section on grid and table properties:
Preview Link
View the updated section in the compare branch for this pull request
Preview | Diff