Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add naming guidance for blockquote, meter and time roles #1231

Merged
merged 5 commits into from
Nov 6, 2019

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Oct 28, 2019

Fixes #1077.


Preview | Diff

@zcorpan zcorpan requested a review from mcking65 October 28, 2019 20:28
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Naming guidance for blockquote, meter and time roles.

The full IRC log of that discussion <Jemma> Topic: Naming guidance for blockquote, meter and time roles
<carmacleod> github: https://github.com//pull/1231
<Jemma> https://github.com//issues/1212
<carmacleod> mck: part of me is wondering whether we should discourage accessible label on these
<carmacleod> sarah: I agree that it's not a good pattern. Can we say that you can't name them?
<sarah_higley> ^ sorry, I was unclear. I meant "can we say you can't use aria-label on them?"
<carmacleod> mck: we don't think there's value labelling it unless there's a visible label (for blockquote and time)
<carmacleod> mck: trying to imagine real world examples of time - labelling it is probably just going to cause screen reader problems
<carmacleod> mck: blockquote - if there's a visible label, that would work ok in screen readers
<carmacleod> jamesn: I don't like the word "discretionary" in the table - it sounds to "positive"
<carmacleod> mck: used to have "Sometimes", "Never", "Occasionally", but that didn't work too well
<carmacleod> jamesn: Ok, let's not worry about the word.
<carmacleod> mck: we can discourage it in the comments if it's "Discretionary"
<Jemma> I think we need more strong guidance rather than discretion.
<Jemma> s/need/need to provide

Co-Authored-By: Matt King <a11yThinker@Gmail.com>
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
@carmacleod
Copy link
Contributor

@jongund I think your 2 comments above probably belong in PR #1109, which is about aria-level.

aria-practices.html Outdated Show resolved Hide resolved
@zcorpan zcorpan requested a review from mcking65 November 5, 2019 09:44
@carmacleod carmacleod self-requested a review November 5, 2019 12:47
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you!

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Naming guidance for blockquote, meter and time roles.

The full IRC log of that discussion <MarkMccarthy> TOPIC: Naming guidance for blockquote, meter and time roles
<zcorpan> GitHub: https://github.com//pull/1231
<MarkMccarthy> Matt_King: zcorpan, could you share what we have?
<MarkMccarthy> zcorpan: yeah. the diff isn't so big for this, fortunately
<MarkMccarthy> zcorpan: there was an editorial change for the text which used to read "not supported by Assitive Technologies" under the time role
<MarkMccarthy> Matt_King: did you raise an issue with ARIA about prohibited naming etc.?
<MarkMccarthy> zcorpan: haven't done that yet
<MarkMccarthy> jamesn: you'll hit resistance on that, though I agree
<MarkMccarthy> Matt_King: well, we'll see what happens
<MarkMccarthy> Matt_King: jamesn, are you okay with what we have for blockquote now?
<MarkMccarthy> jamesn: sure, your explanation sounds reasonable
<MarkMccarthy> zcorpan: "if a visible label is present, associating with aria-labelled by could benefit AT users"
<MarkMccarthy> jamesn: sounds good
<MarkMccarthy> Matt_King: if people are in agreement, i'll merge. we have an approving review from carmacleod
<MarkMccarthy> zcorpan: nice!
<MarkMccarthy> Matt_King: no objections, so we'll move forward

@mcking65 mcking65 merged commit 7cb6858 into master Nov 6, 2019
@mcking65 mcking65 deleted the zcorpan/naming-by-role-1.2 branch November 6, 2019 05:51
@zcorpan
Copy link
Member Author

zcorpan commented Nov 6, 2019

@mcking65 I've filed w3c/aria#1117 on ARIA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update section on providing accessible names and descriptions for ARIA 1.2
4 participants