Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox Pattern and Examples: Convert to support draft ARIA 1.2 specification #1255

Merged
merged 54 commits into from
Nov 15, 2019
Merged

Combobox Pattern and Examples: Convert to support draft ARIA 1.2 specification #1255

merged 54 commits into from
Nov 15, 2019

Commits on Nov 12, 2019

  1. Initial draft of 1.2 proposal

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    a842b94 View commit details
    Browse the repository at this point in the history

  2. Update documentation for aria-controls

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    92d529b View commit details
    Browse the repository at this point in the history

  3. Remove references to ArIA 1.0 pattern

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    e33a189 View commit details
    Browse the repository at this point in the history

  4. Move 1.0 examples to root and delete 1.0 and 1.1 directories

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    c7c77c1 View commit details
    Browse the repository at this point in the history

  5. Update list of examples

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    7d5c0c5 View commit details
    Browse the repository at this point in the history

  6. Change 1.1 to 1.2 in title and footer of autocomplete-list example page

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    93be0a9 View commit details
    Browse the repository at this point in the history

  7. Update paths in and revise text of combobox-autocomplete-both.html

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    c0634d9 View commit details
    Browse the repository at this point in the history

  8. Add similar examples list back to the autocomplete-list example

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    cc9c10f View commit details
    Browse the repository at this point in the history

  9. Update paths and text for combobox-autocomplete-none.html

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    dfefb81 View commit details
    Browse the repository at this point in the history

  10. added grid combobox example to branch

    @jongund @mcking65
    jongund authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    252768b View commit details
    Browse the repository at this point in the history

  11. added grid combobox example to branch

    @jongund @mcking65
    jongund authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    673d6ab View commit details
    Browse the repository at this point in the history

  12. updated regression tests for updated autocomplete both, list and none… 

    … examples
    @jongund @mcking65
    jongund authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    34e1afc View commit details
    Browse the repository at this point in the history

  13. Remove ARIA 1.2 from grid combo title and change version in title tag… 

    … to 1.2
    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    4057291 View commit details
    Browse the repository at this point in the history

  14. Update list of similar examples and fix design pattern URI

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    4787873 View commit details
    Browse the repository at this point in the history

  15. Fix URIs for main doc in keyboard section

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    5cf2c0e View commit details
    Browse the repository at this point in the history

  16. Editorial revisions to states and props table in grid combo page

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    d0187c3 View commit details
    Browse the repository at this point in the history

  17. Update footer nav link in grid combo page

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    e7369da View commit details
    Browse the repository at this point in the history

  18. Update combobox pattern per 1.2

    @zcorpan @mcking65
    zcorpan authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    a5b491e View commit details
    Browse the repository at this point in the history

  19. Add a note about aria-owns

    @zcorpan @mcking65
    zcorpan authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    4678982 View commit details
    Browse the repository at this point in the history

  20. Note in the intro that combobox can be editable or non-editable

    @zcorpan @mcking65
    zcorpan authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    aa08d15 View commit details
    Browse the repository at this point in the history

  21. Tweak text that compare combobox to listbox and menu buttons

    @zcorpan @mcking65
    zcorpan authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    68d07ae View commit details
    Browse the repository at this point in the history

  22. Try describing comboboxes aseither editable or select-only, to avoid … 

    …non-editable
    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    976996e View commit details
    Browse the repository at this point in the history

  23. Additional editorial revisions to combobox pattern description

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    54e1a28 View commit details
    Browse the repository at this point in the history

  24. Add 'editable' to example titles

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    e79a813 View commit details
    Browse the repository at this point in the history

  25. Revise combobox pattern keyboard interactions to describe select-only… 

    … behaviors
    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    5455675 View commit details
    Browse the repository at this point in the history

  26. Revise pattern listbox keyboard interactions to more clearly reflect … 

    …select-only combobox interactions
    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    1587eeb View commit details
    Browse the repository at this point in the history

  27. Editorial revisions to pattern grid keyboard interaction

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    fc2add9 View commit details
    Browse the repository at this point in the history

  28. editorial revisions to pattern introduction

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    529c522 View commit details
    Browse the repository at this point in the history

  29. Editorial revisions to tree keyboard interaction in the pattern.

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    3987903 View commit details
    Browse the repository at this point in the history

  30. Rename Combo Box to Combobox for consistency

    @zcorpan @mcking65
    zcorpan authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    a9bad46 View commit details
    Browse the repository at this point in the history

  31. Change spelling of pop-up to popup for consistency

    @zcorpan @mcking65
    zcorpan authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    cd492e7 View commit details
    Browse the repository at this point in the history

  32. Prefer <label> when possible

    @zcorpan @mcking65
    zcorpan authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    09f6496 View commit details
    Browse the repository at this point in the history

  33. Fix eslint errors in combobox example

    @zcorpan @mcking65
    zcorpan authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    3db149c View commit details
    Browse the repository at this point in the history

  34. aria-controls should always be set, not just when the popup is visible

    @zcorpan @mcking65
    zcorpan authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    b8efc3f View commit details
    Browse the repository at this point in the history

  35. Fix note markup in keyboard interaction section for the combobox in t… 

    …he pattern
    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    36ccb4b View commit details
    Browse the repository at this point in the history

  36. In combobox pattern keyboard interaction for combobox, clarify enter … 

    …key behavior
    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    4206c94 View commit details
    Browse the repository at this point in the history

  37. Pattern keyboard interaction for combobox: change moves selection to … 

    …moves focus
    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    267e816 View commit details
    Browse the repository at this point in the history

  38. updated regression tests for grid combobox

    @jongund @mcking65
    jongund authored and mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    51653ae View commit details
    Browse the repository at this point in the history

  39. Pattern keyboard interaction section for tree: fix note about aria-or… 

    …ientation
    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    feb730e View commit details
    Browse the repository at this point in the history

  40. Editorial revisions to states and properties in the pattern

    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    2b14de2 View commit details
    Browse the repository at this point in the history

  41. This file is no longer needed, since example has been deleted

    @jongund
    jongund authored Nov 12, 2019
    Configuration menu
    Copy the full SHA
    acc2c68 View commit details
    Browse the repository at this point in the history

  42. Pattern introduction: revise comparison to listbox and menu button to… 

    … avoid incorrect use of the term 'value'.
    @mcking65
    mcking65 committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    ffa2f7c View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Fix broken (and ignored) autocomplete-both test

    Valerie Young committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    280b678 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Apply editorial changes to pattern suggested by @carmacleod and @char… 

    …markk.

Co-Authored-By: Mark McCarthy <charmarkk@gmail.com>
    @mcking65 @charmarkk
    mcking65 and charmarkk authored Nov 14, 2019
    Configuration menu
    Copy the full SHA
    439f65d View commit details
    Browse the repository at this point in the history

  2. Revise trigger conditions list per Carolyn's suggestion

    @mcking65
    mcking65 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    83f5ff6 View commit details
    Browse the repository at this point in the history

  3. Apply 3 more editorial changes to pattern suggested by @carmacleod. 

    Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
    @mcking65 @carmacleod
    mcking65 and carmacleod authored Nov 14, 2019
    Configuration menu
    Copy the full SHA
    4a9d3ea View commit details
    Browse the repository at this point in the history

  4. Fix white space in structural roles section (unrelated to PR) 

    Co-Authored-By: Mark McCarthy <charmarkk@gmail.com>
    @mcking65 @charmarkk
    mcking65 and charmarkk authored Nov 14, 2019
    Configuration menu
    Copy the full SHA
    a10305a View commit details
    Browse the repository at this point in the history

  5. Remove aria-multiline guidance from states and props section of pattern

    @mcking65
    mcking65 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    dd6f6c0 View commit details
    Browse the repository at this point in the history

  6. Remove aria-haspopup from examples where it is not necessary

    @mcking65
    mcking65 committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    e51ad04 View commit details
    Browse the repository at this point in the history

  7. Fix visual design issues with combobox examples 1-3 

    Part of #1255.
    @zcorpan
    zcorpan committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    73ca367 View commit details
    Browse the repository at this point in the history

  8. Tweak styles of combobox examples 1-3 to look nicer

    @zcorpan
    zcorpan committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    d2f0e5a View commit details
    Browse the repository at this point in the history

  9. fix constant option remove/append bug, fix label styling

    @smhigley
    smhigley committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    ccd56b7 View commit details
    Browse the repository at this point in the history

  10. Remove tests for aria-haspopup on listbox examples

    Valerie Young committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    312ba70 View commit details
    Browse the repository at this point in the history

  11. Fix stylelint config to correctly ignore only forced-colors media fea… 

    …ture
    @zcorpan
    zcorpan committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    f535354 View commit details
    Browse the repository at this point in the history