Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Menubar Example: Improve high contrast support and refactor javascript #1359

Merged
merged 67 commits into from
Jul 19, 2020
Merged
Show file tree
Hide file tree
Changes from 64 commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
2edd0b9
initial files for navigation menubar
jongund Mar 20, 2020
9e9fdf2
updated script
jongund Mar 20, 2020
4b308a7
update menubar navigation
jongund Mar 24, 2020
fc2074e
udpated menubar navigation
jongund Mar 24, 2020
5ddc2cd
updated documentation on keyboard support
jongund Mar 24, 2020
f52ee72
updated tests to identify failing tests due to Issue 1358
jongund Mar 31, 2020
4cd1d1d
updated test with SPACE key
jongund Apr 1, 2020
a7a83c5
updated focus styling
jongund Apr 3, 2020
63026bb
added a 1 pixel border to menubar to improve high contrast support
jongund Apr 20, 2020
a3eadca
updated the example to use SVG images to improve color contrast in hi…
jongund Apr 21, 2020
db7e292
preload images
jongund Apr 21, 2020
ff3b1f2
Editorial revisions to accessibility features
mcking65 Apr 21, 2020
569c2a0
Editorial revision to enter and space documentation
mcking65 Apr 21, 2020
4c7497a
Update links to source js and css
mcking65 Apr 21, 2020
3495c57
Fix href in footer link to design pattern
mcking65 Apr 21, 2020
71cd9c3
updated focus styling to use solid borders
jongund Apr 22, 2020
ba5aabd
add SVG separator
jongund Apr 22, 2020
ad02ba3
Merge branch 'issue1357-navigation-menubar-js' of github.com:w3c/aria…
jongund Apr 30, 2020
7ea221b
started updating mouse behavior
jongund Apr 30, 2020
4da3f0b
fixing mouse over issues with menubar navigation
jongund Apr 30, 2020
19b630f
updated CSS to fix positioning bug
jongund Apr 30, 2020
97b4c6d
fixed high contrast issue
jongund Apr 30, 2020
0e29a31
updated CSS to fix positioning bug
jongund Apr 30, 2020
a10de63
initial files for navigation menubar
jongund Mar 20, 2020
2415e70
updated script
jongund Mar 20, 2020
cd7b413
update menubar navigation
jongund Mar 24, 2020
b146364
udpated menubar navigation
jongund Mar 24, 2020
0b1e03a
updated documentation on keyboard support
jongund Mar 24, 2020
ae62001
updated tests to identify failing tests due to Issue 1358
jongund Mar 31, 2020
e2dc479
updated test with SPACE key
jongund Apr 1, 2020
7a14422
updated focus styling
jongund Apr 3, 2020
975c59b
updated the example to use SVG images to improve color contrast in hi…
jongund Apr 21, 2020
3adcbd5
preload images
jongund Apr 21, 2020
29166b2
Editorial revisions to accessibility features
mcking65 Apr 21, 2020
768e676
Editorial revision to enter and space documentation
mcking65 Apr 21, 2020
c13212e
Update links to source js and css
mcking65 Apr 21, 2020
eb21c4f
Fix href in footer link to design pattern
mcking65 Apr 21, 2020
58bfc96
add SVG separator
jongund Apr 22, 2020
f7e9401
started updating mouse behavior
jongund Apr 30, 2020
33b86c2
fixing mouse over issues with menubar navigation
jongund Apr 30, 2020
70e7e4e
updated CSS to fix positioning bug
jongund Apr 30, 2020
dce83bf
fixed high contrast issue
jongund Apr 30, 2020
fcc6cf2
updated CSS to fix positioning bug
jongund Apr 30, 2020
0db3a72
fixed test conflicts
jongund May 5, 2020
1f8f17f
fixing conflicts from last merge
jongund May 6, 2020
bb7185e
fixed bug with popup menus not staying open when using the left and r…
jongund Jun 2, 2020
55c0e90
merged master
jongund Jul 6, 2020
cfaaf7e
added strict
jongund Jul 6, 2020
0ddbaf8
preload images, and fixed links in landing pages
jongund Jul 7, 2020
4fac474
restored original navigation menubar
jongund Jul 9, 2020
380d02b
Merge branch 'master' into issue1357-navigation-menubar-js
jongund Jul 13, 2020
443dd81
removed original menubar navigation example files and test
jongund Jul 13, 2020
af2214b
fixed mouse hover issue
jongund Jul 15, 2020
910176c
fixed cross referencing links
jongund Jul 15, 2020
ebbfd5e
fixed background mouse down event to not cancel event propagation
jongund Jul 15, 2020
d68fe77
fixed broken link in disclosure menu button example
jongund Jul 15, 2020
b64a364
improved color contrast support
jongund Jul 16, 2020
86bef29
removed unused preloaded images
jongund Jul 16, 2020
ffedc76
fixed label for tutition pop out menu
jongund Jul 16, 2020
404ddbf
fixed href missing a #
jongund Jul 16, 2020
7863f68
updated documentation
jongund Jul 16, 2020
8dd6c56
updated docuemntation
jongund Jul 17, 2020
5f52431
updated accessibility documentation related to SVG images
jongund Jul 17, 2020
195c634
Merge branch 'master' into issue1357-navigation-menubar-js
mcking65 Jul 17, 2020
282d2ca
fixed most of gitter issue, still some on pull down menus
jongund Jul 18, 2020
f5d9081
fixed menu gitter on focus and hover
jongund Jul 18, 2020
15e3450
aria-practices.html: update links to menubar examples
mcking65 Jul 19, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/disclosure/disclosure-navigation.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ <h1>Example Disclosure for Navigation Menus</h1>
<ul>
<li><a href="disclosure-faq.html">Example Disclosure (Show/Hide) for Answers to Frequently Asked Questions</a></li>
<li><a href="disclosure-img-long-description.html">Example Disclosure (Show/Hide) for an Image Description</a></li>
<li><a href="../menubar/menubar-1/menubar-1.html">Navigation Menubar Example</a></li>
<li><a href="../menubar/menubar-navigation.html">Navigation Menubar Example</a></li>
</ul>
<h2>Example Usage Options</h2>
<p>
Expand All @@ -47,9 +47,9 @@ <h2>Example Usage Options</h2>
</p>
<label for="arrow-behavior-switch">
<input type="checkbox" id="arrow-behavior-switch" checked>
Include optional support for arrow keys, <kbd>Home</kbd>, and <kbd>End</kbd>
Include optional support for arrow keys, <kbd>Home</kbd>, and <kbd>End</kbd>
</label>

<section>
<h2 id="ex_label">Example</h2>
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="Start of" ></div>
Expand Down
118 changes: 118 additions & 0 deletions examples/menubar/css/menubar-navigation.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
.menubar-navigation {
margin: 0;
margin-top: 0.5em;
margin-bottom: 0.5em;
padding: 7px;
font-size: 110%;
list-style: none;
background-color: #eee;
border: #eee solid 1px;
border-radius: 5px;
}

.menubar-navigation li {
margin: 0;
padding: 0;
border: 0 solid black;
list-style: none;
}

.menubar-navigation > li {
display: inline-block;
position: relative;
}

.menubar-navigation > li li {
display: block;
}

.menubar-navigation [role="menu"] [role="menuitem"],
.menubar-navigation [role="menu"] [role="separator"] {
display: block;
width: 12em;
margin: 0;
}

.menubar-navigation [role="menuitem"],
.menubar-navigation [role="separator"] {
padding: 6px;
background-color: #eee;
border: 0px solid #eee;
color: black;
border-radius: 5px;
}

.menubar-navigation [role="menuitem"] svg {
fill: currentColor;
stroke: currentColor;
}

.menubar-navigation [role="menuitem"] svg.down {
padding-left: 0.125em;
}

.menubar-navigation [role="menuitem"] svg.right {
position: absolute;
padding-top: 0.35em;
right: 0.75em;
}

.menubar-navigation [role="menuitem"][aria-expanded="true"] svg.down {
transform: rotate(180deg);
}

.menubar-navigation [role="menuitem"][aria-expanded="true"] svg.right {
transform: rotate(90deg) translate(5px, -5px);
}

.menubar-navigation > li > [role="menuitem"] {
display: inline-block;
}

.menubar-navigation [role="menu"] {
display: none;
position: absolute;
margin: 0;
padding: 0;
}

.menubar-navigation [role="group"] {
margin: 0;
padding: 0;
}

.menubar-navigation [role="menu"] {
display: none;
}

.menubar-navigation [role="separator"] {
padding-top: 3px;
background-image: url('../images/separator.svg');
background-position: center;
background-repeat: repeat-x;
}

/* focus styling */

.menubar-navigation.focus {
padding: 6px;
border: #034575 solid 2px;
}

.menubar-navigation [role="menu"] {
padding: 7px 4px;
border: 2px solid #034575;
border-radius: 5px;
background-color: #eee;
}

.menubar-navigation [role="menuitem"][aria-expanded="true"],
.menubar-navigation [role="menuitem"]:focus,
.menubar-navigation [role="menuitem"]:hover {
padding: 2px;
border: 4px solid #034575;
background: #034575;
color: #fff;
outline: none;
margin: 0;
}
6 changes: 3 additions & 3 deletions examples/menubar/images/down-arrow-focus.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions examples/menubar/images/down-arrow.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions examples/menubar/images/separator.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions examples/menubar/images/up-arrow.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading