Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update menubutton examples: High Contrast Support and APG Coding Practices #1401

Merged
merged 61 commits into from
Nov 10, 2020
Merged
Show file tree
Hide file tree
Changes from 59 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
5fdad05
initial update to the menu button links
jongund May 5, 2020
be5669a
Merge branch 'master' into issue1399-menubutton-updates
jongund May 6, 2020
ffecc52
fixed mouse click bug on background
jongund May 6, 2020
b8f5492
Merge branch 'master' into issue1399-menubutton-updates
jongund May 7, 2020
bc10254
updated code
jongund May 7, 2020
fe857a0
added test case
jongund May 7, 2020
e5f06bf
update menu button for actions
jongund May 8, 2020
4797fe3
updated menu button examples
jongund May 12, 2020
a214b48
updated CSS
jongund May 12, 2020
57f2ead
updated CSS
jongund May 12, 2020
948b951
updated CSS
jongund May 12, 2020
0455cff
deleted unused files
jongund May 13, 2020
4441b6d
fixed space key bug to activate link
jongund Jun 2, 2020
457269b
merged master
jongund Jul 2, 2020
e885531
updated test case
jongund Jul 2, 2020
bd5e049
fixed failing regression test on windows
jongund Jul 7, 2020
e8f16e0
updated regression test fix for Windows 10
jongund Jul 14, 2020
3907f96
fixed windows 10 adjustment
jongund Jul 14, 2020
1d159da
Merge branch 'master' into issue1399-menubutton-updates
jongund Jul 14, 2020
ba0a9c1
Merge branch 'master' into issue1399-menubutton-updates
jongund Jul 20, 2020
a12d2de
updated down arrow to use inline SVG to support high contrast OS sett…
jongund Jul 20, 2020
299d74a
deleted unused images, since now using inline SVG
jongund Jul 20, 2020
1791f4f
updated accessibility documentation
jongund Jul 20, 2020
2be2078
fixed bugs with aria-expanded and aria-activedescendant
jongund Jul 20, 2020
95731e8
simplified focus styling of menu buttons
jongund Jul 22, 2020
b3aaabe
updated file refrencences
jongund Jul 22, 2020
e1a5588
merged master
jongund Aug 10, 2020
d156f8e
updated regression test
jongund Aug 18, 2020
a01ea87
Merge branch 'master' into issue1399-menubutton-updates
jongund Aug 19, 2020
41caf3e
updated regression test
jongund Aug 19, 2020
545a258
due to problem with travis marked two tests as failing
jongund Aug 19, 2020
8e092f5
Fix menu-button test's scrolling bug
Aug 21, 2020
f583807
Merge branch 'master' into issue1399-menubutton-updates
jongund Aug 22, 2020
0276fe1
updated code for action output
jongund Aug 22, 2020
2f40ce8
*using down arrow rather than click to open menu for action example*
jongund Aug 23, 2020
fd01d07
Corrections to test comments suggested by Carolyn
mcking65 Sep 1, 2020
e0d47e6
Editorial revisions to accessibility features documentation for clarity
mcking65 Sep 1, 2020
e5b4fef
Rebase caused conflicts so instead merging latest commits from master…
mcking65 Sep 1, 2020
c16693a
Accessibility Features documentation: Clarify description of why CSS …
mcking65 Sep 15, 2020
9f7b9b8
Merge branch 'master' into issue1399-menubutton-updates
jongund Sep 16, 2020
ef69cdd
updated buttons to have 1 pixel border by default
jongund Sep 16, 2020
3ac4eb6
Merge branch 'master' into issue1399-menubutton-updates
jongund Sep 30, 2020
02a6222
updated description of use of currentColor
jongund Sep 30, 2020
7c8d4e3
fixed CSS linting error
jongund Sep 30, 2020
c7c3d5d
fixed CSS linting bug
jongund Sep 30, 2020
61a2ade
fixed CSS linting bug
jongund Sep 30, 2020
ce2aa75
Merge branch 'master' into issue1399-menubutton-updates
Oct 22, 2020
c6be89f
Run prettier
Oct 22, 2020
60c8f0a
updated JS to use classes
jongund Oct 25, 2020
0b64498
updated JS to use classes
jongund Oct 25, 2020
b2c81cf
updated JS to use classes
jongund Oct 25, 2020
f8119db
Merge branch 'master' into issue1399-menubutton-updates
jongund Oct 25, 2020
8bc07df
fixed eslint errors
jongund Oct 25, 2020
5a3c8ae
updated event handler function names to us 'on' instead of 'handle'
jongund Oct 25, 2020
edf42b4
added code pen support
jongund Oct 25, 2020
05195ea
update high contrast documentation
jongund Oct 27, 2020
37700a7
fixed conflicts
jongund Nov 9, 2020
1a845c8
fixing linter errors
jongund Nov 9, 2020
ef92636
fixing linter errors
jongund Nov 9, 2020
05fb793
Minor editorial revisions to hich contrast mode documentation.
mcking65 Nov 10, 2020
dfa5664
Minor editorial revision to navigation menu button intro
mcking65 Nov 10, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 0 additions & 56 deletions examples/menu-button/css/MenubuttonLinks.css

This file was deleted.

82 changes: 82 additions & 0 deletions examples/menu-button/css/menu-button-actions.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
.menu-button-actions {
margin: 0;
padding: 0;
}

.menu-button-actions button {
margin: 0;
padding: 6px;
display: inline-block;
position: relative;
background-color: #034575;
border: 1px solid #034575;
font-size: 0.9em;
color: white;
border-radius: 5px;
}

.menu-button-actions [role="menu"] {
display: none;
position: absolute;
margin: 0;
padding: 7px 4px;
border: 2px solid #034575;
border-radius: 5px;
background-color: #eee;
}

.menu-button-actions [role="menuitem"],
.menu-button-actions [role="separator"] {
margin: 0;
padding: 6px;
display: block;
width: 4em;
background-color: #eee;
color: black;
border-radius: 5px;
}

.menu-button-actions [role="separator"] {
padding-top: 3px;
background-image: url("../images/separator.svg");
background-position: center;
background-repeat: repeat-x;
}

.menu-button-actions button svg.down {
padding-left: 0.125em;
fill: currentColor;
stroke: currentColor;
}

.menu-button-actions button[aria-expanded="true"] svg.down {
transform: rotate(180deg);
}

/* focus styling */

.menu-button-actions button:hover,
.menu-button-actions button:focus,
.menu-button-actions button[aria-expanded="true"] {
padding: 4px;
border: 3px solid #034575;
background: #eee;
color: #222;
outline: none;
margin: 0;
}

.menu-button-actions [role="menuitem"].focus,
.menu-button-actions [role="menuitem"]:focus {
padding: 4px;
border: 2px solid #034575;
background: #034575;
color: #fff;
outline: none;
margin: 0;
}

input.action:focus {
outline: 2px solid #034575;
background: #def;
}
78 changes: 78 additions & 0 deletions examples/menu-button/css/menu-button-links.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
.menu-button-links {
margin: 0;
font-size: 110%;
}

.menu-button-links button {
margin: 0;
padding: 6px;
display: inline-block;
position: relative;
background-color: #034575;
border: 1px solid #034575;
font-size: 0.9em;
color: white;
border-radius: 5px;
}

.menu-button-links [role="menu"] {
margin: 0;
padding: 7px 4px;
list-style: none;
display: none;
position: absolute;
border: 2px solid #034575;
border-radius: 5px;
background-color: #eee;
}

.menu-button-links [role="menuitem"],
.menu-button-links [role="separator"] {
margin: 0;
padding: 6px;
display: block;
width: 24em;
background-color: #eee;
border: none;
color: black;
border-radius: 5px;
}

.menu-button-links [role="separator"] {
padding-top: 3px;
background-image: url("../images/separator.svg");
background-position: center;
background-repeat: repeat-x;
}

.menu-button-links button svg.down {
padding-left: 0.125em;
fill: currentColor;
stroke: currentColor;
}

.menu-button-links button[aria-expanded="true"] svg.down {
transform: rotate(180deg);
}

/* focus styling */

.menu-button-links button:hover,
.menu-button-links button:focus,
.menu-button-links button[aria-expanded="true"] {
padding: 4px;
border: 3px solid #034575;
background: #eee;
color: #222;
outline: none;
margin: 0;
}

.menu-button-links [role="menuitem"]:focus {
padding: 4px;
border: 2px solid #034575;
background: #034575;
color: #fff;
outline: none;
margin: 0;
}
47 changes: 0 additions & 47 deletions examples/menu-button/css/menuButtonAction.css

This file was deleted.

Loading