Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily comment out flaky tests #1488

Merged
merged 1 commit into from
Aug 9, 2020
Merged

Conversation

spectranaut
Copy link
Contributor

This is a bit unsatisfying of a PR after several hours of investigation, but there are a few flaky tests that I don't want to trip people up until they are fixed.

This PR comments out the tests that I saw failing most frequently in the CI. I commented the tests out so that we would see them reported as "missing" in the regression coverage report. This issue is being used to keep track of the tests: #1415

@jongund
Copy link
Contributor

jongund commented Aug 9, 2020

@spectranaut
Valerie thank you for checking into this and verifying my experience. Hopefully can get to the bottom of the issue.

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @spectranaut ... looks good. Merging.

@mcking65 mcking65 merged commit b1e4f2c into master Aug 9, 2020
@mcking65 mcking65 deleted the comment-flaky-tests-temp branch August 9, 2020 22:24
michael-n-cooper pushed a commit that referenced this pull request Aug 9, 2020
Infrastructure: Temporarily comment out flaky tests (pull #1488)

Disable a few unreliable regression tests that we don't want to impede other work while we determine the root cause of the inconsistent test behavior.
This change comments out tests that fail most frequently in CI.
The regression test coverage report will report them as missing.
The work to resolve the root issue is tracked by issue #1415.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants