Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menubar Examples: Remove outdated files #1490

Merged
merged 6 commits into from
Aug 24, 2020
Merged

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Aug 9, 2020

Removes examples/menubar/menubar-2 directory, which contained the editor menubar replaced by pull request #1356.

@carmacleod
Copy link
Contributor

carmacleod commented Aug 10, 2020

Note that this only fixes the first bullet of issue #1457.
Would be nice to fix the rest as well.

@mcking65 mcking65 force-pushed the remove-unused-menubar-files branch from 11b66c6 to a74e443 Compare August 19, 2020 06:51
@mcking65 mcking65 marked this pull request as draft August 19, 2020 07:38
@spectranaut
Copy link
Contributor

I added to commits to finish the last "to do" items listed here: #1457

Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks like you got 'em all! Thanks for regenerating the coverage docs!

@mcking65 mcking65 marked this pull request as ready for review August 22, 2020 00:37
@mcking65 mcking65 changed the title Remove outdated menubar example files Menubar Examples: Remove outdated files Aug 24, 2020
@mcking65 mcking65 merged commit 51cf5d7 into master Aug 24, 2020
@mcking65 mcking65 deleted the remove-unused-menubar-files branch August 24, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menubar Examples: Remove (or replace) all remaining instances of "menubar-1" and "menubar-2"
3 participants