Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Add navigation systems design pattern #1492

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Aug 10, 2020

Resolve #89 and #353 by adding a design pattern section for navigation systems.

Preview Link

View proposed pattern in the compare branch


Preview | Diff

@mcking65 mcking65 self-assigned this Aug 10, 2020
@carmacleod carmacleod linked an issue Aug 10, 2020 that may be closed by this pull request
@carmacleod
Copy link
Contributor

Nice work so far, @mcking65 !
This will be a welcome addition to the APG.

I think each of the examples will need a note right above the example (or near the top of the example page) that says something like:

Important: Read Navigation Systems for Sites and Apps before using this example.

Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case it's helpful, here are the relevant ARIA attributes for each example.
Wasn't sure whether or not to add aria-label[ledby] as well.

aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
@jongund
Copy link
Contributor

jongund commented Aug 11, 2020

@mcking65
@carmacleod
Matt thank you for getting this section started, I think it is important.

A few weeks ago I started on a menu button example for "Mythical University":
menu button navigation example

Just need to add regression tests, the most painful part of developing an example, given the unreliability and instability of the AVA testing system.

I think we also need to talk about the following issues:

  1. Number of tab stops in the navigation "menu"
  2. Visual affordances for indicating interaction
    2.1 Down arrow before for disclosure menus (e.g. like details/summary)
    2.2. Down arrow after for popup menus (e.g. menubars and menu buttons)
  3. The NAVIGATION landmark should be used for navigational links for the website/app, not collection of links to external resources
  4. Have a tab only example of the navigation "menu"
  5. Have a mega menu example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants