Infrastructure: Convert spellcheck to GitHub Action #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
force-pushed
the
github-action-cspell
branch
5 times, most recently
from
92c2143
to
d45da6a
Compare
nschonni
changed the title
nschonni
force-pushed
the
github-action-cspell
branch
3 times, most recently
from
06b1ebc
to
d5c3753
Compare
nschonni
force-pushed
the
github-action-cspell
branch
from
d5c3753
to
8dfba50
Compare
|
OK, per discussion in telecon yesterday, we are taking the plunge and making spelling a required check ... we'll see how it goes!! @nschonni thank you again for all your work to help us ensure quality before ship. |
|
@mcking65 it won't actually be "required" unless you see branch policy, but I'll spin up a separate discussion on that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the spellchecking only if the
aria-practices.htmlor HTML files in theexampledirectory. Add a problem matcher so that comments are left on the lines with spelling issues in PRs and pushes.The main change that this swap brings, is that GitHub Actions don't have the concept of "allowed failures", so these will be blocking failures.
Closes #1497