-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Separate kbd cords for multiple key strokes #1611
Conversation
Regression test coverage:Examples without any regression tests:
Examples missing some regression tests:
Example pages with Keyboard or Attribute table rows that do not have data-test-ids:
SUMMARY:55 example pages found. ERROR - missing tests: Please write missing tests for this report to pass. |
@mcking65 actually I'm seeing in https://github.com/w3c/aria-practices/wiki/APG-Editorial-Style-Guidelines#using-the-kbd-tag that you're recommending the combination. Is there a reason for that? |
@nschonni I assume it’s because the keys have to be pressed together? |
The only real edge case I can see, where this approch is better is: vs. ctrl + + |
And maybe Ctrl + - then? 😂 |
replaced by #3093 |
Related to this, it would be nice to have a little styling on the
kbd
element, but I'm not sure if that's something that is supposed to come from the common CSS rather than specific to this repo. Some examples of the styling over here https://auth0.github.io/kbd/Preview | Diff