Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Update build and test process for default branch rename to main #1779

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

jesdaigle
Copy link
Contributor

@jesdaigle jesdaigle commented Feb 24, 2021

Resolves #1421

README.md Outdated
@@ -1,10 +1,10 @@
[![Build Status](https://travis-ci.com/w3c/aria-practices.svg?branch=master)](https://travis-ci.com/w3c/aria-practices)
[![Build Status](https://travis-ci.com/w3c/aria-practices.svg?branch=main)](https://travis-ci.com/w3c/aria-practices)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably just be deleted, since Travis isn't used anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR incoming. :)

README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -1,10 +1,10 @@
[![Build Status](https://travis-ci.com/w3c/aria-practices.svg?branch=master)](https://travis-ci.com/w3c/aria-practices)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

README.md Outdated
@@ -1,10 +1,10 @@
[![Build Status](https://travis-ci.com/w3c/aria-practices.svg?branch=master)](https://travis-ci.com/w3c/aria-practices)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

README.md Outdated
@@ -101,7 +101,7 @@ offending character is indicated by the number `8` after the colon. Change the
variable `value_nodes` to `valueNodes` in your source file to eliminate this
error.

To see the complete list of style rules that are applied by ESLint, review the [.eslint.json](https://github.com/w3c/aria-practices/blob/master/.eslint.json) file in the root of the project.
To see the complete list of style rules that are applied by ESLint, review the [.eslint.json](.eslint.json) file in the root of the project.
Copy link
Contributor

@nschonni nschonni Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps, just saw the relative link works, but the filename was wrong before

Suggested change
To see the complete list of style rules that are applied by ESLint, review the [.eslint.json](.eslint.json) file in the root of the project.
To see the complete list of style rules that are applied by ESLint, review the [.eslintrc.json](.eslintrc.json) file in the root of the project.

@mcking65 mcking65 changed the title update files to use main Infrastructure: Update build and test process for default branch rename to main Feb 25, 2021
Base automatically changed from master to main March 3, 2021 18:13
@mcking65 mcking65 merged commit 0e7acce into w3c:main Mar 3, 2021
kdoberst pushed a commit to kdoberst/aria-practices that referenced this pull request May 14, 2021
…me to main (w3c#1779)

* update files to use main

* updated readme with suggestions

* updated readme with suggestions
kdoberst pushed a commit to kdoberst/aria-practices that referenced this pull request May 14, 2021
…me to main (w3c#1779)

* update files to use main

* updated readme with suggestions

* updated readme with suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the master branch
3 participants