-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Accordion example code and behavior #1830
Conversation
10-second review: this is so much nicer than what was there before! Arrow keys are not needed when any section can be collapsed. I guess we need the whole review checklist thing. |
Thanks for the review and adding the preview link @carmacleod! Somehow I always forget that 😅 |
be3c1d7
to
a8c3f6f
Compare
… arrow key nav and forced single open state in the basic example.
Thanks @smhigley for the changes.
|
@smhigley |
@smhigley |
Can we have update on review so that we can see whether it can be merged? If not, we can add this PR to next week meeting agenda since we will review another accordion PR 1834 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial review done; looks good!
Resolves #1819 with the following changes:
Preview link
General cleanup:
id
attributes to match other example pagesBehavior changes:
Review checklist