Infrastructure: Make 'npm run regression' run as headless by default #1888
Conversation
|
We could add a message when running |
zcorpan
force-pushed
the
bocoup/ava-headless
branch
from
4c0aa24 to
dba7a53
Compare
|
|
|
Rebase this PR on |
zcorpan
force-pushed
the
bocoup/ava-headless
branch
from
dba7a53 to
dbfd4cd
Compare
|
Rebased. |
mcking65
added
the
Infrastructure
mcking65
changed the title
zcorpan
force-pushed
the
bocoup/ava-headless
branch
from
dbfd4cd to
4ee5298
Compare
| @@ -9,7 +9,7 @@ const queryElement = require('./util/queryElement'); | |||
| const queryElements = require('./util/queryElements'); | |||
|
|
|||
| let session, geckodriver; | |||
| const firefoxArgs = process.env.CI ? ['-headless'] : []; | |||
| const firefoxArgs = process.env.DEBUG ? [] : ['-headless']; | |||
There was a problem hiding this comment.
Makes sense! Should this get documented somewhere, or is that already done on the wiki?
There was a problem hiding this comment.
It's not documented yet, but the OP says to change the wiki when merging.
(I think it would be better to have the documentation in the tree, so PRs like this one can update the documentation in the PR, and people can review the documentation changes...)
There was a problem hiding this comment.
Right, it would be flipping the current instructions around CI=1 npm run regression
|
Thanks @jesdaigle I've updated the wiki and emailed public-aria-practices@ |
|
@zcorpan wrote: @zcorpan wrote:>(I think it would be better to have the documentation in the tree, so PRs like this one can update the documentation in the PR, and people can review the documentation changes...) This might fit into the redesign. Perhaps the about page in the redesign could be a collection of cards like the patterns and fundamentals page and we could have cards for various aspects of the contributor documentation that open to pages for topics, such as regression tests. |
Use 'DEBUG=1 npm run regression' to opt-in to non-headless.
Fixes #1885
These docs should be updated when merging this.