Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio Example: Add scroll-to feature using aria-activedescendant #2056

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Radio Example: Add scroll-to feature using aria-activedescendant #2056

merged 4 commits into from
Nov 2, 2021

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Oct 6, 2021

@jongund jongund requested review from jnurthen and mcking65 October 6, 2021 20:14
@jongund jongund linked an issue Oct 7, 2021 that may be closed by this pull request
When using aria-activedescendant, the focused element is not scrolled into the visible area #2052
Closed
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern QA for APG Examples Related to improve the quality and the acceptance of APG examples labels Oct 18, 2021
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Oct 18, 2021
@zcorpan zcorpan changed the title added scroll to feature to radio example using aria-activedescendant Radio Example: Add scroll-to feature using aria-activedescendant Nov 2, 2021
@jesdaigle jesdaigle merged commit 3873e42 into main Nov 2, 2021
@jesdaigle jesdaigle deleted the radio-scroll-to branch November 2, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howard-e howard-e howard-e approved these changes

@zcorpan zcorpan zcorpan approved these changes

@jnurthen jnurthen Awaiting requested review from jnurthen

@mcking65 mcking65 Awaiting requested review from mcking65

Assignees
No one assigned
Labels
Example Page Related to a page containing an example implementation of a pattern QA for APG Examples Related to improve the quality and the acceptance of APG examples
Projects
Radio Group Pattern and Examples Development Project
Status: Complete
Milestone
1.2 Release 1
Development

Successfully merging this pull request may close these issues.

When using aria-activedescendant, the focused element is not scrolled into the visible area
5 participants
@jongund @zcorpan @howard-e @mcking65 @jesdaigle