Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related Documents links - Insufficient contrast ratio #2388

Closed
wants to merge 1 commit into from

Conversation

jnurthen
Copy link
Member

Fixes #2384

@mcking65
Copy link
Contributor

@jongund

Could you please check to see if this is still an issue and make a new PR to make this simple one line change if so?

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed PR2388: Related Documents links - Insufficient contrast ratio by jnurthen.

The full IRC log of that discussion <jugglinmike> subtopic: PR2388: Related Documents links - Insufficient contrast ratio by jnurthen
<jugglinmike> github: https://github.com//pull/2388
<jugglinmike> Matt_King: This is somewhat old. I wonder if anything has changed in a way that has made this unnecessary
<jugglinmike> Matt_King: Given that it's a one-line change, it might be easier to re-create the pull request rather than rebase the existing one
<jugglinmike> jamesn: The tab on the page looks to be the same color, and I don't see why one would fail and the other would not
<jugglinmike> Matt_King: Is this unique to the "Landmarks" page?
<jugglinmike> jamesn: Yes
<jugglinmike> Matt_King: I want to re-do these pages because they're hard to maintain in their current form
<jugglinmike> Matt_King: Since this is a minor issue, we may want to just let it be until we are able to take on the larger issue
<jugglinmike> jamesn: On the other hand, this is super simple, so we could fix it without much effort
<jugglinmike> Matt_King: That's true; it could be several months before we can improve the pages. If someone wants to land a quick fix now, that would also be good
<jugglinmike> jamesn: Okay, I'll do that, now

@mcking65
Copy link
Contributor

Replaced by #2738

@mcking65 mcking65 closed this Jul 10, 2023
@mcking65 mcking65 deleted the jnurthen/issue2384 branch July 10, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Related Documents links - Insufficient contrast ratio
3 participants