Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on APG vs. browser multiselect listbox keyboard pattern #2476

Merged
merged 2 commits into from
Oct 2, 2022

Conversation

smhigley
Copy link
Contributor

Fixes #2193

Adds a note with the wording we discussed in a meeting on the Rearrangeable Listbox multiselect example.

@smhigley smhigley added the editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. label Sep 15, 2022
@smhigley smhigley requested a review from mcking65 September 15, 2022 01:25
@smhigley smhigley self-assigned this Sep 15, 2022
@smhigley smhigley changed the base branch from main to move-examples September 15, 2022 01:25
@mcking65 mcking65 force-pushed the listbox-keyboard-note branch from 7dd1949 to aacf644 Compare October 2, 2022 22:37
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @smhigley!

Looks great. I just made one minor revision to include a link back to the keyboard interaction section of the pattern where the multiple selection model is defined.

@mcking65
Copy link
Contributor

mcking65 commented Oct 2, 2022

Since this is a minor editorial revision and I see a thumbs up from @JAWS-test, who raised the original issue, I am merging without further review.

Note: this is not going directly to main. It is will be merged with the restructuring project. I'm doing it this way so we can avoid fixing it twice. The move-examples branch should be in main in a couple weeks or so.

@mcking65 mcking65 merged commit 42ea301 into move-examples Oct 2, 2022
@mcking65 mcking65 deleted the listbox-keyboard-note branch October 2, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listbox with Multiple Selection: "Recommended selection model" is uncommon
2 participants