-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure examples, patterns, and practices: Fix links to practices and patterns #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcking65
changed the title
Fix links to practices and patterns
Restructure examples, patterns, and practices: Fix links to practices and patterns
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of issue #2418, which is part of the Restructure repository project
Now that practices are merged into the new content tree we are building in the move-examples branch in PR #2417, this PR updates the href attributes of links to practices and ensures link text is consistent with target page titles. It also fixes other broken links as discovered.
To make the changes for this PR, I'm examining all links that include a
#
and are not already a link to a new pattern location (do not include "-pattern.html") and do not link to the ARIA spec (do not have a class that ends with "-reference"). Using search pattern: