Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of a Hide/show widget for showing a long description of a image and faq details #250

Merged
merged 40 commits into from
Jan 31, 2017
Merged

Initial implementation of a Hide/show widget for showing a long description of a image and faq details #250

merged 40 commits into from
Jan 31, 2017

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Jan 23, 2017

No description provided.

@mcking65 mcking65 self-assigned this Jan 24, 2017
@mcking65
Revise example title
79697b7 
modified:   examples/hide-show/hide-show-1/hide-show-1.html:
Changed title tag and H1 element to include the word disclosure and remove the part about describing an image.
@mcking65
modified: examples/hide-show/hide-show-1/hide-show-1.html:
5a5f331 
* The image and table were     outside the ex1 div; moved them inside.
* eliminated an unnecessary div with id example.
* Add H2 example heading per template.
* Added screen reader separators around example per template.
* Put html source in pre tags instead of div tag.
@mcking65
Added Disclosure Design Pattern Placeholder
a50306d 
modified aria-practices.html:
In the design pattern section, added a subsection placeholder for the disclosure (show/hide) design pattern with a link to issue #9.
@mcking65
Modified examples/hide-show/hide-show-1/hide-show-1.html:
dce9894 
* Updated title and H1 to match title in placeholder section in aria-practices.html.
* Updated links back to aria-practices to have disclosure pattern target.
* Initial draft of intro paragraph.
@mcking65
Added link to issue 244
74fb4d8 
Modified examples/hide-show/hide-show-1/hide-show-1.html
at beginning of example, added link to issue #244 for tracking work on the example.
@mcking65
Copy link
Contributor

@jongund,

I pushed some changes to your hide-show branch. So, please do a git pull in your hide-show branch and have a look at the log.

Before we merge, will you please:

  1. Rename the directory to "disclosure".
  2. Optional: Consider eliminating the 3rd-level directory with the "-1" suffix. Do you really think we will have multiple examples? Even if we do, it seems simpler to put multiple html files in the disclosure directory.
  3. Fetch the latest from master and rebase your feature branch.

Commands to rebase assuming you have git bash open to your fork of w3c/aria-practices:

Git checkout master
git pull
git checkout hide-show
git rebase master

Many thanks!!

mcking65
mcking65 requested changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jongund, see my comment with requested changes on the conversation tab.

@jongund
Copy link
Contributor Author

jongund commented Jan 26, 2017 via email

@jongund jongund changed the title Initial implementation of a Hide/show widget for showing a long description of a image Initial implementation of a Hide/show widget for showing a long description of a image and faq details Jan 26, 2017
@jongund
Copy link
Contributor Author

jongund commented Jan 26, 2017 via email

jongund and others added 10 commits January 26, 2017 13:23
@jongund
updated focus styling of button using underline
0936269
@jongund
added links between examples
aafcf6d
@jongund
update documentation on tab index being added by Javascript
6e58e05
@jongund
bug in documentation
ce335a2
@jongund
fixed problems with links and removed return key support
c9ee253
@jongund
added RETURN back into the design pattern
c20dedb
@jongund
updated keyboard documentation
f569900
@mcking65
modified examples/disclosure/disclosure-img-long-description.html:
0b4f5fd 
* Revised title tag and h1
* Made image label refer to the short description.
* Put the ex1 div around the complete example.
* added screen reader separators around ex1 div.
* Wrote intro paragraph.
* Added link to issue 244.
* Editorial changes to keyboard table.
* Editorial changes to state/property table.
* Made links back to disclosure pattern in main doc.
@mcking65
Complete initial draft of long description disclosure example
9875dfc 
Modified examples/disclosure/disclosure-img-long-description.html:
* Replaced link to issue #244 with link to issue 264, the review issue.added lin
@mcking65
Initial draft of FAQ disclosure for issue #244
769495a 
modified examples/disclosure/disclosure-faq.html:
* Made all the same corrections that I made to the image description disclosure.
* Added link to review issue 265
@mcking65
Copy link
Contributor

@jongund, I completed changes and pushed to your fork.
I will merge now.

@mcking65
Removed original hide-show directory and content
e9576ad 
deleted:    examples/hide-show/hide-show-1/css/hideShow1.css
deleted:    examples/hide-show/hide-show-1/hide-show-1.html
deleted:    examples/hide-show/hide-show-1/images/collapsed-16.png
deleted:    examples/hide-show/hide-show-1/images/expanded-16.png
deleted:    examples/hide-show/hide-show-1/images/minard.png
deleted:    examples/hide-show/hide-show-1/js/buttonExpanded.js
@mcking65 mcking65 merged commit b930590 into w3c:master Jan 31, 2017
@mcking65 mcking65 mentioned this pull request Jan 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

Assignees

@mcking65 mcking65

Labels
None yet
Projects
Command, Toggle, Menu, and Disclosure Button Patterns and Examples Development Project
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jongund @mcking65