-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link checker #2543
Link checker #2543
Conversation
See #2147 for a simpler solution than a custom script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/JustinBeckwith/linkinator seems to have all that. You could also use the extra logic in the |
Apologies @nschonni I didn't realize you had a PR open which covered the same feature that Paul and I were working on. If we knew that we would have touched base earlier. We did try Linkinator as we were authoring the PR, but we were a bit irked that it did not check hash links (see issue), which is a limitation off-the-shelf link checkers seem to have, and this was the initial reason that led us to decide to implement a custom link checker. |
No problem at all! My main point with other PR was just to leverage as much externally supported code. Only suggestion might be to leverage Linkinator (or something else) if it covers 80% of the cases, to minimize the amount this project has to maintain |
I suggest we satisfy our immediate need with this custom script. Perhaps as a long term maintenance strategy, could we fork linkenator, add missing capability, offer it back in a PR, and then opefully be able to use it in the future? Would be interested in sizing that next year. |
Adds a link checker which will run in CI. It can also be run locally with
npm run link-checker
.Huge thanks to @Paul-Clue at Bocoup who worked with me on this feature from beginning to end.