-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid examples and Feed Display: Rename html files to remove camel casing #2597
Conversation
Failed link checker is caused by an external page experiencing some downtime. |
Preview is here: https://deploy-preview-188--aria-practices.netlify.app/aria/apg/patterns/feed/examples/feed/ The current version of wai-aria-practices does not support the feed-display name changes, support for that will be in w3c/wai-aria-practices#186, so that change will not be reflected in the preview. |
@alflennik pls let me know when this is ready for merge by sending email directly to my Meta email. |
@mcking65 This PR is not included in the w3c/wai-aria-practices#189 release because I found that it was not needed to fix the 404s, and there is still an issue with the preview build for this PR that I have not solved yet. I'll let you know when it's ready to review and we can try to get it out in next week's release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alflennik thank you, looks good.
There are a few pages in the APG which have capitalizations in their URLs, which can cause issues especially with Netlify which automatically lowercases all URLs. This PR updates the advanced-data-grid, layout-grids and data-grids pages as well as the feed-display page to use train-case instead of camelCase.
Part of fix for w3c/wai-aria-practices#192.
Should not be merged until PR w3c/wai-aria-practices#187 is merged.
WAI Preview Link failed to build on 'Update site files' step. (Last tried on Wed, 01 Feb 2023 22:25:33 GMT).