Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid examples and Feed Display: Rename html files to remove camel casing #2597

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

alflennik
Copy link
Contributor

@alflennik alflennik commented Feb 1, 2023

There are a few pages in the APG which have capitalizations in their URLs, which can cause issues especially with Netlify which automatically lowercases all URLs. This PR updates the advanced-data-grid, layout-grids and data-grids pages as well as the feed-display page to use train-case instead of camelCase.

Part of fix for w3c/wai-aria-practices#192.

Should not be merged until PR w3c/wai-aria-practices#187 is merged.


WAI Preview Link failed to build on 'Update site files' step. (Last tried on Wed, 01 Feb 2023 22:25:33 GMT).

@alflennik
Copy link
Contributor Author

Failed link checker is caused by an external page experiencing some downtime.

@alflennik
Copy link
Contributor Author

Preview is here: https://deploy-preview-188--aria-practices.netlify.app/aria/apg/patterns/feed/examples/feed/

The current version of wai-aria-practices does not support the feed-display name changes, support for that will be in w3c/wai-aria-practices#186, so that change will not be reflected in the preview.

@mcking65
Copy link
Contributor

mcking65 commented Feb 1, 2023

@alflennik pls let me know when this is ready for merge by sending email directly to my Meta email.

@alflennik alflennik changed the title WIP: Rename grid examples to address wai-aria-practices issue 186 Rename grid examples to address wai-aria-practices issue 186 Feb 1, 2023
@alflennik
Copy link
Contributor Author

@mcking65 This PR is not included in the w3c/wai-aria-practices#189 release because I found that it was not needed to fix the 404s, and there is still an issue with the preview build for this PR that I have not solved yet. I'll let you know when it's ready to review and we can try to get it out in next week's release.

@mcking65 mcking65 changed the title Rename grid examples to address wai-aria-practices issue 186 Rename html files of grid examples to remove camel casing Feb 13, 2023
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alflennik thank you, looks good.

@mcking65 mcking65 changed the title Rename html files of grid examples to remove camel casing Grid examples and Feed Display: Rename html files to remove camel casing Feb 22, 2023
@mcking65 mcking65 merged commit bfeb2a7 into main Feb 22, 2023
@mcking65 mcking65 deleted the rename-grid-examples branch February 22, 2023 16:33
@mcking65 mcking65 added Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation and removed Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation labels Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants