Hiding Semantics Practice Page: Add missing word "that" #2704
Conversation
|
This change (https://deploy-preview-222--aria-practices.netlify.app/aria/apg/practices/hiding-semantics/#presentation_role_effects) seems good to me. |
There was a problem hiding this comment.
@frozenzia, great catch, thank you!!
I used the suggestion feature of the PR to request two changes.
- change from "which" to "that" because the clause is essential.
- Add a comma after the independent "for example" clause.
content/practices/hiding-semantics/hiding-semantics-practice.html
Outdated
Show resolved
Hide resolved
mcking65
changed the title
mcking65
added
editorial
|
Hi @frozenzia we would like to include this on the upcoming Tuesday release, could you please apply the change that Matt suggested? Thanks! |
|
@ccanash , I would if I could, but I see "Merging is blocked -- The base branch restricts merging to authorized users." Sorry if I'm just being dense, somehow. I'm not very experienced at all in contributing to projects like this, and in the past when I have, the merging has always been handled by the "team in charge". But I'm definitely willing to help if we can just figure out what I should do at this point. And now I've written all that out it occurs to me that you asked me to "apply the change" that Matt suggested, not do any sort of merging. I'm sorry, but I'm still not seeing where/what I should do. |
Co-authored-by: Matt King <a11yThinker@Gmail.com>
|
@ccanash, had another stab at this after my workday, think I understand now what it was I was supposed to do. "Unresolved" Matt's comment, and that let me then commit the change he suggested. Hope that's all good now. |
|
Thank you @frozenzia for finding this problem and submitting a fix!! |
mcking65
modified the milestones:
H1/2023 Content Updates,
2023-06-20 Publication Pull Requests
WAI Preview Link (Last built on Fri, 09 Jun 2023 20:40:42 GMT).