Infrastructure: Update localhost
references for regression tests
#2749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2636
Node v17+ deprioritised IPv4 addresses in favour of IPv6 with a change to dns.setDefaultResultOrder. This was done without a happy-eyeballs implementation which meant the loopback address used when running the regression tests resolved to
::1
rather than the IPv4 loopback,127.0.0.1
which geckodriver expected. So this PR now explicitly uses127.0.0.1
.Alternatively, we could have added
--dns-result-order=ipv4first
to the running script, or addeddns.setDefaultResultOrder('ipv4first');
, but would eventually remove it as the happy-eyeballs implementation is now included in v20.Note the current environment details for the regression tests when running the node setup:
WAI Preview Link (Last built on Tue, 11 Jul 2023 21:24:38 GMT).