Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortable Table Example: Improve CSS so it works when all columns are sortable #2910

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

kentslaney
Copy link
Contributor

@kentslaney kentslaney commented Jan 25, 2024

When all the columns are sortable, none of the header buttons create space in the layout, causing the th row's height to collapse. Fixes #2904.


WAI Preview Link (Last built on Thu, 25 Jan 2024 23:33:33 GMT).

Copy link
Contributor

@a11ydoer a11ydoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested change - removing position;absolute - solves the overlapping table header problem. Thanks so much for the PR, @kentslaney

@a11ydoer a11ydoer requested a review from shirsha February 6, 2024 20:12
Copy link

@curtbellew curtbellew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this change out via codepen and it works well

@mcking65 mcking65 changed the title Fix th height collapse with all sortable headers Sortable Table Example: Improve CSS so it works when all columns are sortable Feb 26, 2024
@mcking65 mcking65 merged commit 81d807d into w3c:main Feb 26, 2024
1 check passed
Copy link

@shirsha shirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and review completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sortable table fails without at least one column that is not sorted
5 participants