Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio Group Pattern and Examples: Remove Enter key as a way of checking a radio #2964

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Radio Group Pattern and Examples: Remove Enter key as a way of checking a radio #2964

merged 2 commits into from
Apr 7, 2024

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Mar 19, 2024 •
edited by daniel-montalvo
Loading

  • The documentation does not include information about the enter key, it was an undocumented behavior
  • The regression tests for radio group examples do not include any tests for the enter key

WAI Preview Link (Last built on Sun, 07 Apr 2024 17:43:37 GMT).

@daniel-montalvo daniel-montalvo mentioned this pull request Mar 19, 2024
Closed
@mcking65 mcking65 changed the title Removed enter key support form radio button examples Radio Group Pattern and Examples: Remove Enter key as a way of checking a radio Mar 26, 2024
@mcking65 mcking65 linked an issue Apr 7, 2024 that may be closed by this pull request
Should radio buttons activate with Enter key when focused? #2954
Closed
@mcking65 mcking65 merged commit 9d3fe80 into main Apr 7, 2024
22 of 23 checks passed
@mcking65 mcking65 deleted the update/issue-2954-radio branch April 7, 2024 17:51
@mcking65 mcking65 mentioned this pull request Apr 7, 2024
Closed
@howard-e howard-e mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2024-04-09 Publication Pull Requests
Development

Successfully merging this pull request may close these issues.

Should radio buttons activate with Enter key when focused?
2 participants
@jongund @mcking65