Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratings Slider: Use buttontext instead of linktext system color in high contrast mode #3025

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

jongund
Copy link
Contributor

@jongund jongund commented May 21, 2024

I think the use of buttontext system color is a better choice than linktext for styling the slider when in Windows 10/11 high contrast modes. This change makes no difference on high contrast on macOS.

Preview of updated rating slider


WAI Preview Link (Last built on Tue, 04 Jun 2024 18:26:17 GMT).

@jongund jongund changed the title updated media query color for forced-colors media query updated forced-colors media query to use buttontext rather than linktext May 22, 2024
@jongund jongund changed the title updated forced-colors media query to use buttontext rather than linktext updated forced-colors media query for rating slider May 22, 2024
aria-practices Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? Pls remove

@mcking65
Copy link
Contributor

mcking65 commented Jun 4, 2024

@jongund

seems like there is accidental addition of an empty file named aria-practices

@mcking65 mcking65 requested a review from a11ydoer June 11, 2024 18:27
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Change high contrast system color in ratings slider.

The full IRC log of that discussion <jugglinmike> Topic: Change high contrast system color in ratings slider
<jugglinmike> github: https://github.com//pull/3025
<jugglinmike> jongund: I changed the system color link text to "button text". It just makes our widgets look more like form controls than links
<jugglinmike> s/button text/buttontext/
<jugglinmike> Matt_King: why are two files changed?
<jugglinmike> jongund: cspell checks CSS files for spelling
<jugglinmike> Matt_King: That seems undesirable
<jugglinmike> s/cspell/I also had to change the cspell configuration. cspell/
<jugglinmike> howard-e: I can look into that
<jugglinmike> Matt_King: Does this color change impact all contexts? Or only high-contrast mode?
<jugglinmike> jongund: Only high-contrast mode
<jugglinmike> jongund: Depending on how you test it, you don't necessarily need Windows
<jugglinmike> jongund: In Chrome, for instance, you can use the developer tools to simulate high-contrast mode
<jugglinmike> jongund: This probably won't affect macOS users
<jugglinmike> jongund: The only place I know this pull request will make a difference is in Windows
<jugglinmike> Matt_King: So the pull request should have screenshots of the difference (before and after), and also instructions for how a reviewer can observe the difference themself
<jugglinmike> Jem: I can review once jongund adds that information
<jugglinmike> Matt_King: Okay, I'll assign you, then
<jugglinmike> Matt_King: is this a change you were just trying out for the one slider? Do you think it should be applied to the other examples if people like it?
<jugglinmike> jongund: Yes, I think we should use it elsewhere. Though we only use the "forced colors" media query in one other pattern--feed. I'd also like to add it to other patterns

@a11ydoer
Copy link
Contributor

@jongund I will be waiting for the compared views of forced colors for the review as we discussed at the APG meeting.

@jongund
Copy link
Contributor Author

jongund commented Jun 13, 2024

@a11ydoer

Here is s screenshot of the current rating slider with "dark sky" theme enabled. Slider colors use the same colors as links.
current-slider-apg-dark-sky

Here is s screenshot of the udated rating slider with "dark sky" theme enabled. Slider colors use the same colors as buttons.
updated-slider-apg-dark-sky

Screenshot of Windows 11 control panel for setting "dark sky" theme:
windows-11-color-themes
Note: Windows 10 has similar accessibility settings for a "dark" theme

Use the preview link in the pull request to view the updated slider after you configure windows for "dark" theme:
![https://deploy-preview-325--aria-practices.netlify.app/aria/apg/patterns/slider/examples/slider-rating/]

@mcking65 mcking65 changed the title updated forced-colors media query for rating slider Ratings Slider: Use buttontext instead of linktext system color in high contrast mode Jun 18, 2024
@mcking65 mcking65 requested a review from shirsha June 18, 2024 18:15
Copy link
Contributor

@a11ydoer a11ydoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the screenshots. These met color contrast requirements and look good.

@mcking65 mcking65 merged commit 19347dd into main Jul 23, 2024
11 of 12 checks passed
@mcking65 mcking65 deleted the update/rating-slider branch July 23, 2024 05:45
@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Development

Successfully merging this pull request may close these issues.

4 participants