Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OS-specific modifier key for 'select all text' command in toolbar_toolbar test #3115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use OS-specific modifier key for 'select all text' command in toolbar_toolbar test #3115

wants to merge 2 commits into from

Conversation

stalgiag
Copy link
Contributor

@stalgiag stalgiag commented Sep 16, 2024 •
edited
Loading

This PR adds two small utility methods: isMacOS() and getOSPreferredModifierKey(). The latter utility returns the Keys.META if the OS is macOS and Keys.Control otherwise.

These utilities are then used in the toolbar_toolbar test to ensure that the OS-specific modifier key is used in the "select all text" chord.

see #2735

WAI Preview Link (Last built on Mon, 16 Sep 2024 16:51:17 GMT).

@daniel-montalvo daniel-montalvo mentioned this pull request Sep 16, 2024
Draft
@stalgiag stalgiag changed the title Use Key.META for text area all text selection for OS agnostic testing in toolbar_toolbar Use OS-specific modifier key for select all text in toolbar_toolbar test Sep 16, 2024
@stalgiag stalgiag changed the title Use OS-specific modifier key for select all text in toolbar_toolbar test Use OS-specific modifier key for 'select all text' command in toolbar_toolbar test Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stalgiag