Add version of Alert dialog example ready for final publication review #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes the design to mobile-first, and allows the size of the modal to better fit its contents on desktop
This layer was previously overriding the layout defined by https://www.w3.org/StyleSheets/TR/2016/base.css, as well as acting as a scroll container for the non-dialog content. It was removed in favor of the base layout, and scroll is simply disabled on the body when a dialog is open.
changes the design to mobile-first, and allows the size of the modal to better fit its contents on desktop
This layer was previously overriding the layout defined by https://www.w3.org/StyleSheets/TR/2016/base.css, as well as acting as a scroll container for the non-dialog content. It was removed in favor of the base layout, and scroll is simply disabled on the body when a dialog is open.
…ractices into alertdialog-example
Add Alert Dialog Example and update existing modal dialog.
Modified examples/dialog-modal/alertdialog.html: * Remove header element from related links nav and fix aria-label * remove aria-labelledby from main * remove aria-labeledby from sections that turned them into regions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alert dialog example developed for issue #101 is complete and ready for final review.