WIP: add tests for toolbar/toolbar.html example #845
Conversation
spectranaut
force-pushed
the
bocoup-toolbar
branch
from
fb4bcd5
to
babb7a2
Compare
spectranaut
force-pushed
the
bocoup-toolbar
branch
from
babb7a2
to
0ae7157
Compare
|
@mcking65, currently 2 -- I only wrote two tests (left arrow and right arrow) for the issues I had questions with. I can write the remaining tests and comment them out as we discussed. |
|
The last two commits add tests (expect for the "aria-disabled") and comment them out, with a reference to #847 |
|
@jessebeach, @tatermelon, @sh0ji, even though travis is failing, this is ready for review. The failures are related to a race condition that is not specific to these tests. @spectranaut is debugging the failures separately. |
There was a problem hiding this comment.
@spectranaut This is still a work in progress. Let me know when it should be reviewed for accept.
|
|
||
| const waitAndCheckFocus = async function (t, selector) { | ||
| return t.context.session.wait( | ||
| async function () { |
There was a problem hiding this comment.
Does this need to be async? Everything in the function body is synchronous, unless executeScript is missing an await?
Waiting on questions on toolbar review: #539 (comment)
Also blocking on acceptance of race condition PR: #837