Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Carousel Design Pattern and Examples #945

Merged
merged 20 commits into from
Dec 4, 2018
Merged

Updated Carousel Design Pattern and Examples #945

merged 20 commits into from
Dec 4, 2018

Conversation

jongund
Copy link
Contributor

@jongund jongund commented Nov 16, 2018

@jongund
Copy link
Contributor Author

jongund commented Nov 26, 2018

I think the conflicts have been fixed.

</tr>
</thead>
<tbody>
<th><kbd>Tab</kbd></th>
Copy link
Contributor

@nschonni nschonni Nov 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing opening <tr>

@mcking65 mcking65 mentioned this pull request Dec 3, 2018
@mcking65 mcking65 changed the base branch from master to carousel December 3, 2018 17:51
@mcking65 mcking65 changed the base branch from carousel to carousel-v2 December 4, 2018 00:23
@mcking65
Copy link
Contributor

mcking65 commented Dec 4, 2018

@jongund, I made a new feature branch from the curren tip of master called carousel-v2.

I compared your w3c/carousel branch with the old w3c:carousel branch. It seems that the w3c:carousel branch is now obsolete. So, I made the new carousel-v2 branch.

I am merging this work into carousel-v2. Please:

  1. Base further changes on the carousel-v2 branch.
  2. Confirm whether I should delete the carousel branch.

@mcking65 mcking65 merged commit 21e43f6 into w3c:carousel-v2 Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants