-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add carousel pattern #957
Add carousel pattern #957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good to me @mcking65.
Minor editorial changes, in order of appearance:
"...image carousels where each slide contains nothing more than a single image are common."
-Add "most common" instead of "common."
"Basic: Has rotation , previous slide,..."
-Remove space after rotation, "Has rotation, ..."
(Last bullet under Basic Carousel Elements) "... does not contain the word "slide".
-End punctuation goes inside of quotation marks.
(Under Grouped Carousel Elements) "Choose slide to display".
-End punctuation goes inside of quotation marks.
I like the updated definition but the word "horizontal scrolling" is misleading as carousels do not use a scroll bar to navigate through the slides. |
@charmarkk, many, many thanks for the review!!!
Do we know this for sure? Does adding "most" enhance the meaning? If they are most common, extremely common, or just very common, they are nonetheless common. I'm happy to add "most" if we really know it to be the case, and it meaningfully strengthens the description.
Fixed in commit 8856024.
Fixed in commit 8856024.
Fixed in commit 8856024. BTW, when doing a review, you can put your comments right on the line of the file that needs to be changed. Go to the files tab and click the add comment button by the line the needs changing. That is one way to start a review. You can glob a bunch of comments like that together into a review. |
@shirsha commented:
Thank you Siri. Removed term horizontal scrolling. Please have a look at the latest. |
@jongund, @annabbott, @MichielBijl, I have updated the branch to reflect all feedback from the meeting and Mark's feedback as well. This is now ready for a hopefully final round of review. |
@mcking65 TIL, my thanks! As for the question of adding “most” or not, I mostly mentioned that because it read better. If it’s a question of veracity, however, I’m happy leaving it as is. |
@mcking65 The carousel design pattern looks good to me. I have updated the carousel example to include aria-roledescription on the container section element. |
One review change noted in file. Otherwise looks good. |
Adds a design pattern section for carousels to resolve issue #43.
Preview Pattern in Feature Branch
Carousel pattern in issue43-add-carousel-pattern branch
Preview | Diff