Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guideline for labeling and describing #994
Guideline for labeling and describing #994
Changes from 6 commits
de49b61
713aa1f
ae9a5ed
ce15b81
f0ddc15
3e08581
801539f
61f20ae
8792871
c3ec1e9
6b45492
5727205
07cd850
78e912c
a8651d1
7773aae
54e551b
1bf0f40
16008f5
0f0524f
e131ba5
a40f81b
93c9ec7
9276759
0f48fdb
c686c11
6574f8a
746b200
490eaed
0536ec8
b4a87d8
b596c68
edf4be5
7eb5d5d
bdb67d6
fb4f995
82a8e82
702837a
6c64491
0612ba8
1fd6368
b2e2067
c229c76
8e8ec74
6451e91
ab90611
e2138b9
66f945b
aa068f6
5046495
b977ba5
cccb053
87179dc
1743094
3a005b1
7fb3244
32c5ca0
7806b3e
b530fea
16964ba
9fd5cb4
892ccff
9f8aab4
9604f46
5717568
06cc073
03efdcc
ae90ce1
2cfd46e
df4bab3
ac301c6
a1bd62f
1e56e16
26a4b1c
5602d9f
7e9e68c
66a46fc
1097ac6
47f75ca
063a631
261a261
3e406d2
b87ad08
3d1f8d3
cd01400
73df64e
dab3706
6bf004f
014d0d8
1a25bf3
6b0984b
0a87de0
5e39a2f
37e7136
66095e4
50c9880
7443aa1
4d990cc
c59cc43
774b26c
8a832bd
7f17265
8fb9dbe
a16cf6b
972fe21
47887c0
8de8e44
1d38d3b
debb672
82f3b2f
1ee6b09
0797c1e
03f1ee2
be8ed01
bed7986
ae5938c
f1b5a93
0e10d37
50fc11d
ffc6261
788130a
ef3d1f9
a0f4104
a735dc8
ef6c098
9ffece9
ab3f3cc
9704274
2badb95
875a294
dee5cec
45f39da
f55702a
1db2ced
826e12b
299cab5
af5793c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While implicit/explicit depends on the role, I don't think that is enough info to help the user grasp the important concept here.
The important concept is that there are, broadly speaking, two kinds of labels. One kind of label labels the element and completely represents that element; essentially you could say the label is the element from the user's perspective, e.g., image, heading, link, button, checkbox, radio, menuitem, treeitem. Another kind of label labels another thing, e.g., the label is not the element, e.g., textbox, combobox, toolbar, grid, article, region, table.
One kind of label essentially represents the element and the other kind tells the user here is the purpose of all the junk in here, or here is the kind of junk in here. It labels a input, composite widget, or container.
While These two kinds roughly correspond to implicit (content) and explicit (author), this concept isn't explained well enough for the reader to get a sense of the difference between elements where the label overrides or the label augments.
I think it would be worthwhile if we could help users develop an intuitive understanding of these different kinds of labels/roles/elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've tried to address this, although possibly the new text is repeating things a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to say how this relates to "Name from content" in aria spec.