Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add directory Required Context role to listitem #1062

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Add directory Required Context role to listitem #1062

merged 1 commit into from
Oct 2, 2019

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Sep 26, 2019 •
edited by pr-preview bot
Loading

resolves #1030

Preview | Diff

@scottaohara
Copy link
Member

Per James's mention of low usage, and the fact that role=directory is merely exposed as a list with no tested pairing indicating it as a "directory", it seems to me that we should seriously consider deprecating the role as it does nothing that couldn't be accomplished with a standard list.

@joanmarie
Copy link
Contributor

Per James's mention of low usage, and the fact that role=directory is merely exposed as a list with no tested pairing indicating it as a "directory", it seems to me that we should seriously consider deprecating the role as it does nothing that couldn't be accomplished with a standard list.

Do we have an open issue for the deprecation?

@joanmarie joanmarie self-requested a review October 2, 2019 17:05
@scottaohara
Copy link
Member

Nope @joanmarie. just the mentioning of it in the linked issue. I can/will create a new issue for this though.

@jnurthen jnurthen merged commit 94eddad into master Oct 2, 2019
jnurthen added a commit that referenced this pull request Oct 2, 2019
@jnurthen
Editorial: Add missing directory Required Context role to listitem (#…
4391a10 
…1062)
@jnurthen jnurthen deleted the AddListItemReqContextRole branch October 14, 2019 21:17
carmacleod pushed a commit that referenced this pull request May 7, 2020
@jnurthen @carmacleod
Editorial: Add missing directory Required Context role to listitem (#…
7050629 
…1062)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanmarie joanmarie joanmarie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

listitem role seems to be missing directory as required context role
3 participants
@jnurthen @scottaohara @joanmarie