Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AXE output files for all validation tests, fix bugs and file issues #1594

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

Copy link
Contributor

@jongund jongund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the examples for testing with AXE.

@schne324
Copy link
Contributor

schne324 commented Aug 12, 2021

The existing axe results' json files only include the violations it appears you have included much more than that in the json files. For example, https://github.com/w3c/aria/blob/main/validator-tests/name-prohibited-axe.json

I think it makes sense to only include the violations array but if we want to include everything we should update the existing ones so we have consistency.

@spectranaut
Copy link
Contributor Author

oh I see, I missed that somehow! The results files are all reuploaded with only the violations array, thx @schne324

@jnurthen jnurthen merged commit dbc365c into main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants