Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit value of aria-level from heading role #942

Merged
merged 2 commits into from
May 13, 2019

Conversation

melanierichards
Copy link
Contributor

@melanierichards melanierichards commented Apr 11, 2019

Addresses issue #854


Preview | Diff

@jnurthen
Copy link
Member

link for review

@jnurthen
Copy link
Member

jnurthen commented Apr 17, 2019

I think

If headings are organized into a logical outline, the aria-level attribute is used to indicate the nesting level.

needs rewording now that aria-level is required.

@carmacleod
Copy link
Contributor

Something like:

Headings SHOULD be organized into a logical outline, and the aria-level attribute MUST be used to indicate the nesting level.

?

@carmacleod carmacleod changed the title Remove implicit value from heading role Remove implicit value of aria-level from heading role Apr 18, 2019
@melanierichards
Copy link
Contributor Author

@jnurthen @carmacleod

In the spirit of simplifying shoulds/musts, how about:

To ensure headings are organized into a logical outline, authors MUST use the aria-level attribute to indicate the proper nesting level.

@melanierichards
Copy link
Contributor Author

Made the suggested change!

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@accdc
Copy link
Contributor

accdc commented Apr 29, 2019

As a quick question about the accessibility tree mappings, what heading level will a heading have if there is no implicit level?
Thanks, Bryan

@jnurthen
Copy link
Member

As a quick question about the accessibility tree mappings, what heading level will a heading have if there is no implicit level?
Thanks, Bryan

http://w3c.github.io/aria/#document-handling_author-errors_states-properties states

If a required WAI-ARIA attribute for a given role is missing, user agents SHOULD process the attribute as if the values given in the following table were provided.
In the table the fallback for aria-level is 2

So not supplying a heading level is now an author error, but if a browser is following the fallback guidance it should still expose it with a level of 2.

@accdc
Copy link
Contributor

accdc commented Apr 30, 2019

Excellent, thanks, that was my only concern with this.

@jnurthen jnurthen merged commit ba4689e into w3c:master May 13, 2019
carmacleod pushed a commit that referenced this pull request Oct 17, 2019
* Remove implicit value from heading role
* Adjust heading role verbiage to reflect aria-level authoring expectations
jnurthen pushed a commit that referenced this pull request Sep 8, 2020
* Remove implicit value from heading role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants