-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove implicit value of aria-level from heading role #942
Conversation
I think
needs rewording now that aria-level is required. |
Something like:
? |
In the spirit of simplifying shoulds/musts, how about:
|
Made the suggested change! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
As a quick question about the accessibility tree mappings, what heading level will a heading have if there is no implicit level? |
http://w3c.github.io/aria/#document-handling_author-errors_states-properties states
So not supplying a heading level is now an author error, but if a browser is following the fallback guidance it should still expose it with a level of 2. |
Excellent, thanks, that was my only concern with this. |
* Remove implicit value from heading role * Adjust heading role verbiage to reflect aria-level authoring expectations
* Remove implicit value from heading role
Addresses issue #854
Preview | Diff