Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG 1.1. references SVG 2 as nightly #312

Closed
Elchi3 opened this issue Jun 11, 2021 · 3 comments · Fixed by #316
Closed

SVG 1.1. references SVG 2 as nightly #312

Elchi3 opened this issue Jun 11, 2021 · 3 comments · Fixed by #316

Comments

@Elchi3
Copy link

Elchi3 commented Jun 11, 2021

I added SVG 1.1 to browser-specs, released in v1.35.0. There is no dedicated nightly document for SVG 1.1, so the nightly section actually targets the SVG 2 Editor's Draft.

Originally posted by @tidoust in #273 (comment)

I think this leads to confusion. I think it would be better if SVG 1.1 wouldn't reference SVG 2 as nightly.

For MDN I'm walking through URLs to find their meta data and so when looking up meta data for the SVG 2 spec, it finds the SVG 2 URLs as nightly URLs in the SVG 1.1 data as well as in the SVG 2 data.

You can also see how the data is somewhat duplicated. I rather need the second data object, because that one has the correct title for SVG 2. I can fix this on the consumer side by always preferring a "main data" over "nightly data" but maybe you want to consider not having SVG 2 set as nightly for SVG 1.1.

  {
    "url": "https://www.w3.org/TR/SVG11/",
    "seriesComposition": "full",
    "shortname": "SVG11",
    "series": {
      "shortname": "SVG",
      "currentSpecification": "SVG2",
      "releaseUrl": "https://www.w3.org/TR/SVG/",
      "nightlyUrl": "https://svgwg.org/svg2-draft/"
    },
    "seriesVersion": "1.1",
    "nightly": {
      "url": "https://svgwg.org/svg2-draft/",
      "repository": "https://github.com/w3c/svgwg",
      "sourcePath": "master/Overview.html",
      "pages": [
        "https://svgwg.org/svg2-draft/intro.html",
        "https://svgwg.org/svg2-draft/conform.html",
        "https://svgwg.org/svg2-draft/render.html",
        "https://svgwg.org/svg2-draft/types.html",
        "https://svgwg.org/svg2-draft/struct.html",
        "https://svgwg.org/svg2-draft/styling.html",
        "https://svgwg.org/svg2-draft/geometry.html",
        "https://svgwg.org/svg2-draft/coords.html",
        "https://svgwg.org/svg2-draft/paths.html",
        "https://svgwg.org/svg2-draft/shapes.html",
        "https://svgwg.org/svg2-draft/text.html",
        "https://svgwg.org/svg2-draft/embedded.html",
        "https://svgwg.org/svg2-draft/painting.html",
        "https://svgwg.org/svg2-draft/pservers.html",
        "https://svgwg.org/svg2-draft/interact.html",
        "https://svgwg.org/svg2-draft/linking.html",
        "https://svgwg.org/svg2-draft/idl.html",
        "https://svgwg.org/svg2-draft/implnote.html",
        "https://svgwg.org/svg2-draft/access.html",
        "https://svgwg.org/svg2-draft/animate.html",
        "https://svgwg.org/svg2-draft/refs.html",
        "https://svgwg.org/svg2-draft/eltindex.html",
        "https://svgwg.org/svg2-draft/attindex.html",
        "https://svgwg.org/svg2-draft/propidx.html",
        "https://svgwg.org/svg2-draft/idlindex.html",
        "https://svgwg.org/svg2-draft/mimereg.html",
        "https://svgwg.org/svg2-draft/changes.html"
      ],
      "filename": "Overview.html"
    },
    "seriesNext": "SVG2",
    "release": {
      "url": "https://www.w3.org/TR/SVG11/",
      "pages": [
        "https://www.w3.org/TR/SVG11/expanded-toc.html",
        "https://www.w3.org/TR/SVG11/intro.html",
        "https://www.w3.org/TR/SVG11/concepts.html",
        "https://www.w3.org/TR/SVG11/render.html",
        "https://www.w3.org/TR/SVG11/types.html",
        "https://www.w3.org/TR/SVG11/struct.html",
        "https://www.w3.org/TR/SVG11/styling.html",
        "https://www.w3.org/TR/SVG11/coords.html",
        "https://www.w3.org/TR/SVG11/paths.html",
        "https://www.w3.org/TR/SVG11/shapes.html",
        "https://www.w3.org/TR/SVG11/text.html",
        "https://www.w3.org/TR/SVG11/painting.html",
        "https://www.w3.org/TR/SVG11/color.html",
        "https://www.w3.org/TR/SVG11/pservers.html",
        "https://www.w3.org/TR/SVG11/masking.html",
        "https://www.w3.org/TR/SVG11/filters.html",
        "https://www.w3.org/TR/SVG11/interact.html",
        "https://www.w3.org/TR/SVG11/linking.html",
        "https://www.w3.org/TR/SVG11/script.html",
        "https://www.w3.org/TR/SVG11/animate.html",
        "https://www.w3.org/TR/SVG11/fonts.html",
        "https://www.w3.org/TR/SVG11/metadata.html",
        "https://www.w3.org/TR/SVG11/backward.html",
        "https://www.w3.org/TR/SVG11/extend.html",
        "https://www.w3.org/TR/SVG11/svgdtd.html",
        "https://www.w3.org/TR/SVG11/svgdom.html",
        "https://www.w3.org/TR/SVG11/idl.html",
        "https://www.w3.org/TR/SVG11/java.html",
        "https://www.w3.org/TR/SVG11/escript.html",
        "https://www.w3.org/TR/SVG11/implnote.html",
        "https://www.w3.org/TR/SVG11/conform.html",
        "https://www.w3.org/TR/SVG11/access.html",
        "https://www.w3.org/TR/SVG11/i18n.html",
        "https://www.w3.org/TR/SVG11/minimize.html",
        "https://www.w3.org/TR/SVG11/refs.html",
        "https://www.w3.org/TR/SVG11/eltindex.html",
        "https://www.w3.org/TR/SVG11/attindex.html",
        "https://www.w3.org/TR/SVG11/propidx.html",
        "https://www.w3.org/TR/SVG11/feature.html",
        "https://www.w3.org/TR/SVG11/mimereg.html",
        "https://www.w3.org/TR/SVG11/changes.html"
      ],
      "filename": "Overview.html"
    },
    "title": "Scalable Vector Graphics (SVG) 1.1 (Second Edition)",
    "source": "w3c",
    "shortTitle": "SVG",
    "tests": {
      "repository": "https://github.com/web-platform-tests/wpt",
      "testPaths": [
        "svg"
      ]
    }
  },
  {
    "url": "https://www.w3.org/TR/SVG2/",
    "seriesComposition": "full",
    "shortname": "SVG2",
    "series": {
      "shortname": "SVG",
      "currentSpecification": "SVG2",
      "releaseUrl": "https://www.w3.org/TR/SVG/",
      "nightlyUrl": "https://svgwg.org/svg2-draft/"
    },
    "seriesVersion": "2",
    "seriesPrevious": "SVG11",
    "release": {
      "url": "https://www.w3.org/TR/SVG2/",
      "pages": [
        "https://www.w3.org/TR/SVG2/intro.html",
        "https://www.w3.org/TR/SVG2/conform.html",
        "https://www.w3.org/TR/SVG2/render.html",
        "https://www.w3.org/TR/SVG2/types.html",
        "https://www.w3.org/TR/SVG2/struct.html",
        "https://www.w3.org/TR/SVG2/styling.html",
        "https://www.w3.org/TR/SVG2/geometry.html",
        "https://www.w3.org/TR/SVG2/coords.html",
        "https://www.w3.org/TR/SVG2/paths.html",
        "https://www.w3.org/TR/SVG2/shapes.html",
        "https://www.w3.org/TR/SVG2/text.html",
        "https://www.w3.org/TR/SVG2/embedded.html",
        "https://www.w3.org/TR/SVG2/painting.html",
        "https://www.w3.org/TR/SVG2/pservers.html",
        "https://www.w3.org/TR/SVG2/interact.html",
        "https://www.w3.org/TR/SVG2/linking.html",
        "https://www.w3.org/TR/SVG2/idl.html",
        "https://www.w3.org/TR/SVG2/implnote.html",
        "https://www.w3.org/TR/SVG2/access.html",
        "https://www.w3.org/TR/SVG2/animate.html",
        "https://www.w3.org/TR/SVG2/refs.html",
        "https://www.w3.org/TR/SVG2/eltindex.html",
        "https://www.w3.org/TR/SVG2/attindex.html",
        "https://www.w3.org/TR/SVG2/propidx.html",
        "https://www.w3.org/TR/SVG2/idlindex.html",
        "https://www.w3.org/TR/SVG2/mimereg.html",
        "https://www.w3.org/TR/SVG2/changes.html"
      ],
      "filename": "Overview.html"
    },
    "nightly": {
      "url": "https://svgwg.org/svg2-draft/",
      "repository": "https://github.com/w3c/svgwg",
      "sourcePath": "master/Overview.html",
      "pages": [
        "https://svgwg.org/svg2-draft/intro.html",
        "https://svgwg.org/svg2-draft/conform.html",
        "https://svgwg.org/svg2-draft/render.html",
        "https://svgwg.org/svg2-draft/types.html",
        "https://svgwg.org/svg2-draft/struct.html",
        "https://svgwg.org/svg2-draft/styling.html",
        "https://svgwg.org/svg2-draft/geometry.html",
        "https://svgwg.org/svg2-draft/coords.html",
        "https://svgwg.org/svg2-draft/paths.html",
        "https://svgwg.org/svg2-draft/shapes.html",
        "https://svgwg.org/svg2-draft/text.html",
        "https://svgwg.org/svg2-draft/embedded.html",
        "https://svgwg.org/svg2-draft/painting.html",
        "https://svgwg.org/svg2-draft/pservers.html",
        "https://svgwg.org/svg2-draft/interact.html",
        "https://svgwg.org/svg2-draft/linking.html",
        "https://svgwg.org/svg2-draft/idl.html",
        "https://svgwg.org/svg2-draft/implnote.html",
        "https://svgwg.org/svg2-draft/access.html",
        "https://svgwg.org/svg2-draft/animate.html",
        "https://svgwg.org/svg2-draft/refs.html",
        "https://svgwg.org/svg2-draft/eltindex.html",
        "https://svgwg.org/svg2-draft/attindex.html",
        "https://svgwg.org/svg2-draft/propidx.html",
        "https://svgwg.org/svg2-draft/idlindex.html",
        "https://svgwg.org/svg2-draft/mimereg.html",
        "https://svgwg.org/svg2-draft/changes.html"
      ],
      "filename": "Overview.html"
    },
    "title": "Scalable Vector Graphics (SVG) 2",
    "source": "w3c",
    "shortTitle": "SVG 2",
    "tests": {
      "repository": "https://github.com/web-platform-tests/wpt",
      "testPaths": [
        "svg"
      ]
    }
  },
@tidoust
Copy link
Member

tidoust commented Jun 14, 2021

One of the consistency rules that we currently enforce is that all spec entries in browser-specs have a nightly.url property. I'd prefer to keep that rule. I guess the solution would be to use the /TR URL as nightly URL as well.

I note that the same question exists for IETF specs that @dontcallmedom is adding in #280 and that don't really have a notion of nightly version.

@dontcallmedom
Copy link
Member

+1 on having SVG 1.1 use the TR as its nightly; will this create duplicate extracts in reffy though?

@tidoust
Copy link
Member

tidoust commented Jun 14, 2021

will this create duplicate extracts in reffy though?

That shouldn't change the list of extract files that Reffy creates. In particular, SVG 1.1 and SVG 2 are part of the same series, so we should continue to have only one CSS/IDL extract named SVG for the current spec in the series, meaning SVG 2.

tidoust added a commit that referenced this issue Jun 14, 2021
Fixes #312.

This update required a couple of additional code updates:
- in the code that computes the URL of the repository to use the `repository`
info if it is specified in `specs.json`.
- in the code that computes the `releaseUrl` and `nightlyUrl` to use the
current specification in a series as basis for the info (the code happily
produced a different nightly URL for SVG 1.1 and SVG 2)
tidoust added a commit that referenced this issue Jun 14, 2021
Fixes #312.

This update required a couple of additional code updates:
- in the code that computes the URL of the repository to use the `repository`
info if it is specified in `specs.json`.
- in the code that computes the `releaseUrl` and `nightlyUrl` to use the
current specification in a series as basis for the info (the code happily
produced a different nightly URL for SVG 1.1 and SVG 2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@dontcallmedom @Elchi3 @tidoust and others