Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IntersectionObserver v2 #1210

Closed
wants to merge 1 commit into from
Closed

Add IntersectionObserver v2 #1210

wants to merge 1 commit into from

Conversation

foolip
Copy link
Member

@foolip foolip commented Feb 15, 2024

No description provided.

dontcallmedom
dontcallmedom requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have https://www.w3.org/TR/intersection-observer/ in the list, which points to https://w3c.github.io/IntersectionObserver/ which seems more recently updated than "https://w3c.github.io/IntersectionObserver/v2/"

@foolip
Copy link
Member Author

foolip commented Feb 15, 2024

https://w3c.github.io/IntersectionObserver/v2/ includes things that aren't in v1, namely the trackVisibility parameter for the IntersectionObserver constructor and the isVisible attribute on IntersectionObserverEntry.

I'm adding this because I need it for web-platform-dx/web-features#620, AFAIK this is the only spec that describes the additions.

@szager as the listed editor of the v2 spec, do you have thoughts?

@dontcallmedom
Copy link
Member

see also w3c/IntersectionObserver#468 from a certain @foolip :)

@dontcallmedom
Copy link
Member

with w3c/IntersectionObserver#523 I think there won't be a need to track a v2 separately, so closing

ddbeck added a commit to web-platform-dx/web-features that referenced this pull request Jun 28, 2024
@ddbeck
intersection-observer-v2: spec merged into the Intersection Observe…
018c4fc 
…r spec

w3c/browser-specs#1210
w3c/IntersectionObserver#523
@ddbeck ddbeck mentioned this pull request Jun 28, 2024
Merged
foolip pushed a commit to web-platform-dx/web-features that referenced this pull request Jul 2, 2024
@dependabot @ddbeck
Bump web-specs from 3.11.0 to 3.12.1 (#1283)
6248d52 
`intersection-observer-v2`: spec merged into the Intersection Observer spec

w3c/browser-specs#1210
w3c/IntersectionObserver#523

Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dontcallmedom dontcallmedom dontcallmedom requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foolip @dontcallmedom