Add IETF specs used in MDN #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The information is not systematically available for those
tidoust
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
LGTM.
To further consolidate the code, I believe it would make sense to migrate all URL RegExps to parse-spec-urls one way or the other, and thus move the bits on datatracker URLs from fetch-groups.js to parse-spec-url.js. It requires changing the semantics of the returned structure though: for IETF datatracker URLs, it would seem logic to return ietf as owner, but then that is not the name of the owning organization on GitHub...
This also applies to the URL parsing logic in compute-shortname.js which uses very similar regular expressions.
I'll create an issue to track this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #280