Skip to content

Commit

Permalink
[css-view-transitions-1] Treat auto as an invalid value for `view-t…
Browse files Browse the repository at this point in the history
…ransition-name` (#9764)

* [css-view-transitions-1] Treat `auto` as an invalid value

Closes #9639

* Update css-view-transitions-1/Overview.bs

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>

* Add issue link

---------

Co-authored-by: Khushal Sagar <63884798+khushalsagar@users.noreply.github.com>
  • Loading branch information
noamr and khushalsagar authored Jan 5, 2024
1 parent 541216b commit 2212352
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion css-view-transitions-1/Overview.bs
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;

<pre class=propdef>
Name: view-transition-name
Value: none | <<custom-ident>>
Value: none | auto | <<custom-ident>>
Initial: none
Inherited: no
Percentages: n/a
Expand All @@ -534,6 +534,9 @@ urlPrefix: https://wicg.github.io/navigation-api/; type: interface;
: <dfn>none</dfn>
:: The [=/element=] will not participate independently in a view transition.

: <dfn>auto</dfn>
:: This should be treated as an invalid value, despite being a valid <<custom-ident>>. The property value remains unchanged.

This comment has been minimized.

Copy link
@nt1m

nt1m Jan 5, 2024

Member

@tabatkins @fantasai I don't think this is how custom-ident restrictions are typically defined. Do you know if there are some good examples that can be followed here?

This comment has been minimized.

Copy link
@fantasai

fantasai Jan 5, 2024

Collaborator

Typically we just write in the prose which values are invalid. You don’t add it to the syntax because that implies it’s a real value, and it’ll confuse people.

This comment has been minimized.

Copy link
@nt1m

nt1m Jan 5, 2024

Member

: <dfn><<custom-ident>></dfn>
:: The [=/element=] participates independently in a view transition--
as either an old or new [=/element=]--
Expand Down Expand Up @@ -1940,6 +1943,7 @@ Changes from <a href="https://www.w3.org/TR/2023/WD-css-view-transitions-1-20230
* Copy `color-scheme` from DOM element to ''::view-transition-group()''. See <a href="https://github.com/w3c/csswg-drafts/issues/9276">issue 9276</a>.
* Expose [=auto-skip view transition=] for a {{Document}}, to allow having outbound cross-document transitions preceed programmatic view transiitons. see <a href="https://github.com/w3c/csswg-drafts/issues/9512">issue 9512</a>.
* Add a note about why 'view-transition-name' should be animatable.
* `view-transition-name: auto` should be an invalid value. See <a href="https://github.com/w3c/csswg-drafts/issues/9639">issue 9639</a>.

<h3 id="changes-since-2022-05-25">
Changes from <a href="https://www.w3.org/TR/2023/WD-css-view-transitions-1-20230525/">2022-05-25 Working Draft</a>
Expand Down

0 comments on commit 2212352

Please sign in to comment.