[cssom-view] add shadowRoots parameter to caretPositionFromPoint API.
#10200
Conversation
Per w3c#9932, add `shadowRoots` parameter to `caretPositionFromPoint` API.
siliu1
changed the title
shadowRoots parameter to caretPositionFromPoint API.
Bubble `caret range` out of the shadow roots.
Address PR comments.
|
nit: Could you add links to all the implementation bugs in the PR description? |
Address PR comment.
Could you also add the link for the WebKit implementation bug? If one doesn't exist, we should file one. |
Added WebKit implementation bug for the API. |
Address PR comment.
linked created issue(10230) to the spec.
|
As far as I can tell this works like in https://w3c.github.io/selection-api/#dom-selection-getcomposedranges as @mfreed7 suggested in #9932 (comment) and per the CSSWG resolution. cc @emilio |
| @@ -1148,6 +1145,8 @@ aborting on the first step that returns a value: | |||
|
|
|||
| Note: This {{DOMRect}} object is not <a spec=html>live</a>. | |||
|
|
|||
| Issue(10230): Consider removing <a>caret range</a> concept from <dfn>caret position</dfn> interface. | |||
There was a problem hiding this comment.
This introduces a build error fwiw. caret position is defined twice.
…M behavior r=webidl,smaug,emilio Spec - https://drafts.csswg.org/cssom-view/Overview#dom-document-caretpositionfrompoint Spec PR - w3c/csswg-drafts#10200 TAG Review - w3ctag/design-reviews#949 Differential Revision: https://phabricator.services.mozilla.com/D215184
…M behavior r=webidl,smaug,emilio Spec - https://drafts.csswg.org/cssom-view/Overview#dom-document-caretpositionfrompoint Spec PR - w3c/csswg-drafts#10200 TAG Review - w3ctag/design-reviews#949 Differential Revision: https://phabricator.services.mozilla.com/D215184
Per #9932, add
shadowRootsparameter tocaretPositionFromPointAPI.Implementation bugs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1889503
https://issues.chromium.org/issues/332774620
https://bugs.webkit.org/show_bug.cgi?id=172137
WPT test coverage will be added subsequently.