[cssom][css-conditional][css-images] Switch CSS to use IDL namespace
#437
Conversation
Web IDL added support for namespaces in whatwg/webidl#121 elementSources in css-images-4 is commented out for now because IDL namespaces don't support attributes yet, see w3c#428. Fixes part of https://www.w3.org/Bugs/Public/show_bug.cgi?id=29623
|
The change seems fine. The question is which browsers are willing to try it to see whether it's web-compatible and whether we actually want to change the spec before such trials happen..... |
|
If Web-compat seems likely, then we should change the spec, and put a note that it may be reverted if Web-compat problems are found. If Web-compat seems unlikely, then maybe just put a note that we're in the process of trying this out and the spec may be updated if it ends up working. |
|
Or maybe we can just wait with merging this until someone has tried to ship. |
|
Seems like an obscure approach, is the problem. This way it's documented where the feature itself is documented. |
|
I'm happy to merge this now with a note in CSSOM next to the definition that it's contingent on web-compat. Do you want me to just add that in and merge it, @zcorpan? |
|
SGTM |
gsnedders
requested review from
LeaVerou,
dbaron,
tabatkins,
fantasai and
therealglazou
|
Should add support for namespaces in web-platform-tests's idlharness.js and add an interfaces.html test for cssom (and cssom-view). |
|
That ended up with the wrong pull request number in the commit message... ah, well. |
|
@tabatkins Are there existing bugs reported against browsers for this? |
|
Looks like Chrome has one, at least https://bugs.chromium.org/p/chromium/issues/detail?id=727971 |
|
That looks like the bug on supporting namespace at all, not for "CSS should be a namespace". I guess the question is who is responsible for making sure that UAs actually investigate whether this is shippable. |
|
The second comment on that bug is about the CSS namespace specifically. |
|
Yes, it's about the fact that the functionality is needed for that. I'll be pretty surprised if this change gets made in that bug. Anyway, I landed this in Gecko in https://bugzilla.mozilla.org/show_bug.cgi?id=1455805 but in general the CSSWG really should start filing bugs when spec changes happen.... |
…l namespace CSS CSSOM and other CSS specs were updated in w3c/csswg-drafts#437. Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=29623.
…l namespace CSS (#784) CSSOM and other CSS specs were updated in w3c/csswg-drafts#437. Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=29623.
Web IDL added support for namespaces in
whatwg/webidl#121
elementSourcesin css-images-4 is commented out for now becauseIDL namespaces don't support attributes yet, see #428.
Fixes part of https://www.w3.org/Bugs/Public/show_bug.cgi?id=29623
cc @bzbarsky @domenic @tabatkins @dbaron