[cssom-1] Follow Web IDL extended attribute changes #4930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[TreatNullAs=EmptyString] → [LegacyNullToEmptyString], per whatwg/webidl#870.
emilio
approved these changes
Apr 9, 2020
|
The Web IDL PR is merged and Shepherd seems to be updated; merge at will! |
|
There seems to be some sort of ipr check that seems to be required for me to merge this... @astearns do you know what that is about? |
|
I would think that check is failing because Domenic isn't a member of the CSS WG. |
|
Yeah, but that shouldn't matter because he's from a member company that is part of the group. As I understand it, it just takes someone with the right privileges to push the right button. |
|
https://labs.w3.org/repo-manager/pr/id/w3c/csswg-drafts/4930 looks good to me. @dontcallmedom Do you know why the status of IPR check is "Waiting for status to be reported"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TreatNullAs=EmptyString] → [LegacyNullToEmptyString], per whatwg/webidl#870.
This should not be merged until that PR is merged, and then given a day to reach the link databases.